Conditional warnings: display notification when an outlying operation is ignored due to saved preference

[Claudius]

How to reproduce:

• Load any area that contains a way that reaches outside of the downloaded area.
  
• Try deleting they way either by using DEL on the keyboard or the toolbar button

Result:
Nothing.

Expected result:
User should be able to delete a way even if it contains nodes outside the downloaded area. Warning dialog should be shown in this situation though.

Revision:
2959

[mjulius]

Could it be that you previously checked the "Do not ask again" checkbox and chose "No" in the warning that comes up normally?

If so, go to Advanced Preferences and look for "message.delete_outside_nodes" and set it to true.

[Gubaer]

If so, go to Advanced Preferences and look for "message.delete_outside_nodes" and set it to true.

This solved the issue for me.

I'm turning it into an enhancement and I'm trying to reformulate:

Implement a preference dialog for conditional messages. It should provide a checkbox for each conditional message dialog. If you check the checkbox the message dialog should be displayed, otherwise it shouldn't be displayed.

Rather a minor issue, though, and certainly not a blocker for the next release.

[skyper]

I still think this is a defect, since you are not informed about why your edit is not accepted (delete outside nodes) which is only the side effect of deleting a way. I think JOSM should delete this ways with a warning and provide an option to keep or delete the outside nodes. If you choose delete, JOSM should still warn about not accepting the delete because "message.delete_outside_nodes" is TRUE.

[mjulius]

I don't think it is a good idea to display a warning dialog about a suppressed warning dialog. The most I could imagine is a tooltip like non-modal info window that pops up somewhere and goes away again after a couple of seconds or when it is clicked on.

Regarding the warning in question here it might be a good idea if JOSM would distinguish between nodes that are to be deleted because they have been selected and nodes that are to be deleted because their parent way is deleted.

I am not sure it is a good idea to offer to just not delete these nodes because potentially this leaves a lot of orphaned nodes sitting around. A better option might be to offer to download the referrers for these nodes.

Anyway, the summary line clearly looks like an enhancement to me.

[anonymous]

it is a defect, because the user don't know why it is not working. no message -> frustration

see also #817

[Gubaer]

Removing blocker again and back to enhancement again. It isn't a defect.

Please log in if you flag a ticket as blocker or leave your email address.

[anonymous]

Replying to skyper:

I think JOSM should delete this ways with a warning and provide an option to keep or delete the outside nodes. If you choose delete,should still warn about not accepting the delete because "message.delete_outside_nodes" is TRUE.

JOSM should temporally overwrite "message.delete_outside_nodes" and accept this change.