NullPointerException using openvisible plugin

[rharrison]

Open area and download data in JOSM.
File -> Open Visible
Select gpx files that have data in the visible area.

Repository Root: ​http://josm.openstreetmap.de/svn
Build-Date: 2010-02-01 02:31:31
Last Changed Author: stoecker
Revision: 2916
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: ​http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-01-31 21:44:28 +0100 (Sun, 31 Jan 2010)
Last Changed Rev: 2916

Memory Usage: 187 MB / 1232 MB (26 MB allocated, but free)
Java version: 1.6.0_0

Dataset consistency test:
No problems found

Plugins: AddrInterpolation,DirectUpload,buildings_tools,editgpx,graphview,lakewalker,mappinonosm,measurement,multipoly,openstreetbugs,openvisible,osmarender,remotecontrol,routing,validator,walkingpapers,waydownloader,wmsplugin
Plugin openstreetbugs Version: 19463
Plugin validator Version: 19616
Plugin routing Version: 19475
Plugin graphview Version: 19441
Plugin osmarender Version: 19419
Plugin AddrInterpolation Version: 19422
Plugin measurement Version: 19450
Plugin multipoly Version: 19456
Plugin walkingpapers Version: 19487
Plugin wmsplugin Version: 19626
Plugin editgpx Version: 19434
Plugin openvisible Version: 19465
Plugin mappinonosm Version: 4
Plugin remotecontrol Version: 19471
Plugin DirectUpload Version: 19432
Plugin buildings_tools Version: 28
Plugin lakewalker Version: 19624
Plugin waydownloader Version: 19489

java.lang.NullPointerException

at at.dallermassl.josm.plugin.openvisible.OpenVisibleAction.openFileAsGpx(OpenVisibleAction.java:126)
at at.dallermassl.josm.plugin.openvisible.OpenVisibleAction.actionPerformed(OpenVisibleAction.java:89)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2012)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2335)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:404)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
at javax.swing.AbstractButton.doClick(AbstractButton.java:374)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1688)
at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1732)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
at java.awt.Component.processMouseEvent(Component.java:6108)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:5873)
at java.awt.Container.processEvent(Container.java:2105)
at java.awt.Component.dispatchEventImpl(Component.java:4469)
at java.awt.Container.dispatchEventImpl(Container.java:2163)
at java.awt.Component.dispatchEvent(Component.java:4295)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4461)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4125)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4055)
at java.awt.Container.dispatchEventImpl(Container.java:2149)
at java.awt.Window.dispatchEventImpl(Window.java:2478)
at java.awt.Component.dispatchEvent(Component.java:4295)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:604)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

[matt_gnu]

discovered this bug myself yesterday and dug into the source; apparently GpxReader needs a call to .parse for .data to be valid.

I Commited this change yesterday, which should hpefully fix this: ​http://trac.openstreetmap.org/changeset/20067

As I'm not really familiar with the code for josm/plugins, I'd be glad, if someone would check it though.

[bastiK]

Generally, it should generate the list of files and then use OpenFileAction.

But if it works like this, it should be fine for now.

[anonymous]

You have to follow protocol for plugin updates, or you will break the update mechanism!

​http://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins#Updatingaplugin

[bastiK]

(In [o20078])

[matt_gnu]

thanks for the upload; I didn't think about svn-substvars, but I was considering to not upload a .jar at all because I suspected I might miss something - and it seems I was not *that* wrong ;-)