Opened 11 years ago
Closed 10 years ago
#4375 closed enhancement (wontfix)
authorise -> authorize
Reported by: | Owned by: | Team | |
---|---|---|---|
Priority: | trivial | Milestone: | |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
I just wanted to fix these to american english and found that some files have british names. Could someone with svn access please move them?
# find -name "*.java" | grep -i authoris
./src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationException.java
./src/org/openstreetmap/josm/gui/oauth/AbstractAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OAuthAuthorisationWizard.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedureComboBox.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationClient.java
./src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/ManualAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedure.java
Attachments (0)
Change History (7)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Owner: | changed from team to Gubaer |
---|
At least I have been using british english consistently ;-)
I'll fix it.
comment:3 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Nope, still a lot of them:
# find src/org/ -name "*.java" -print0 | xargs -0 grep -li authoris src/org/openstreetmap/josm/tools/ExceptionUtil.java src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java src/org/openstreetmap/josm/gui/io/DownloadOpenChangesetsTask.java src/org/openstreetmap/josm/gui/ExceptionDialogUtil.java src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClient.java src/org/openstreetmap/josm/gui/oauth/AuthorizationProcedureComboBox.java src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java src/org/openstreetmap/josm/gui/oauth/TestAccessTokenTask.java src/org/openstreetmap/josm/gui/oauth/AbstractAuthorizationUI.java src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorizationUI.java src/org/openstreetmap/josm/gui/oauth/ManualAuthorizationUI.java src/org/openstreetmap/josm/data/oauth/OAuthParameters.java
comment:5 Changed 11 years ago by
Priority: | normal → trivial |
---|
It's fine for me, if, for the sake of UI consistency, all messages are changed to British English. Personally I'm not going to change any Java identifiers any more to British English, unless the respective code has to be touched anyway.
comment:6 Changed 11 years ago by
Owner: | changed from Gubaer to Team |
---|---|
Status: | reopened → new |
comment:7 Changed 10 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Agree with Gubaer, this is something that whoever touches the code can fix if they want. This is a bug report on the level of "the indentation in file X is wrong".
Hm, is more readable with now: