Modify

Opened 10 years ago

Closed 9 years ago

#4375 closed enhancement (wontfix)

authorise -> authorize

Reported by: andre68@… Owned by: Team
Priority: trivial Milestone:
Component: Core Version:
Keywords: Cc:

Description

I just wanted to fix these to american english and found that some files have british names. Could someone with svn access please move them?

# find -name "*.java" | grep -i authoris
./src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationException.java
./src/org/openstreetmap/josm/gui/oauth/AbstractAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OAuthAuthorisationWizard.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedureComboBox.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationClient.java
./src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/ManualAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedure.java

Attachments (0)

Change History (7)

comment:1 Changed 10 years ago by andre68@…

Hm, is more readable with now:

# find -name "*.java" | grep -i authoris
./src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationException.java
./src/org/openstreetmap/josm/gui/oauth/AbstractAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/OAuthAuthorisationWizard.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedureComboBox.java
./src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorisationClient.java
./src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/ManualAuthorisationUI.java
./src/org/openstreetmap/josm/gui/oauth/AuthorisationProcedure.java

comment:2 Changed 10 years ago by Gubaer

Owner: changed from team to Gubaer

At least I have been using british english consistently ;-)

I'll fix it.

comment:3 Changed 10 years ago by Gubaer

Resolution: fixed
Status: newclosed

(In [2861]) fixed #4375: authorise -> authorize

comment:4 Changed 10 years ago by Daeron

Resolution: fixed
Status: closedreopened

Nope, still a lot of them:

# find src/org/ -name "*.java" -print0 | xargs -0 grep -li authoris
src/org/openstreetmap/josm/tools/ExceptionUtil.java
src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java
src/org/openstreetmap/josm/gui/io/DownloadOpenChangesetsTask.java
src/org/openstreetmap/josm/gui/ExceptionDialogUtil.java
src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java
src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClient.java
src/org/openstreetmap/josm/gui/oauth/AuthorizationProcedureComboBox.java
src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java
src/org/openstreetmap/josm/gui/oauth/TestAccessTokenTask.java
src/org/openstreetmap/josm/gui/oauth/AbstractAuthorizationUI.java
src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java
src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorizationUI.java
src/org/openstreetmap/josm/gui/oauth/ManualAuthorizationUI.java
src/org/openstreetmap/josm/data/oauth/OAuthParameters.java

comment:5 Changed 10 years ago by Gubaer

Priority: normaltrivial

It's fine for me, if, for the sake of UI consistency, all messages are changed to British English. Personally I'm not going to change any Java identifiers any more to British English, unless the respective code has to be touched anyway.

comment:6 Changed 10 years ago by Gubaer

Owner: changed from Gubaer to Team
Status: reopenednew

comment:7 Changed 9 years ago by framm

Resolution: wontfix
Status: newclosed

Agree with Gubaer, this is something that whoever touches the code can fix if they want. This is a bug report on the level of "the indentation in file X is wrong".

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.