Modify

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#4149 closed defect (fixed)

v2608: can't undo a way reverse with automatic correction to left/right tags

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: undo reverse left right Cc:

Description

I consistently get an "Unexpected exception" error when I try to undo a way reversal which had implied automatic left/right tags correction

1)I select the "reverse way" command on a way containing tags like value:right / value:left
2)in the "Automatic tag correction" window I accept the proposed changings by selecting "Apply selected changes"
3)If I now select the "Undo the last action" command, it results an "Unexpected exception" window, with the following info:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2009-12-11 02:31:44
Last Changed Author: ce
Revision: 2608
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2009-12-10 23:49:06 +0100 (Thu, 10 Dec 2009)
Last Changed Rev: 2608

Memory Usage: 65 MB / 508 MB (22 MB allocated, but free)
Java version: 1.6.0_17

Dataset consistency test:
{Way id=27982464 version=3 MVDd nodes=[]} not found using Dataset.searchWays()
{Way id=27982473 version=2 MVDd nodes=[]} not found using Dataset.searchWays()
{Way id=27982666 version=2 MVDd nodes=[]} not found using Dataset.searchWays()
{Way id=27982864 version=3 MVDd nodes=[]} not found using Dataset.searchWays()
{Way id=27983075 version=4 MVDd nodes=[]} not found using Dataset.searchWays()

Plugins: editgpx,remotecontrol,validator,waydownloader,wmsplugin
Plugin editgpx Version: 18962
Plugin remotecontrol Version: 18678
Plugin validator Version: 18962
Plugin waydownloader Version: 18962
Plugin wmsplugin Version: 18953

java.lang.NullPointerException

at org.openstreetmap.josm.data.osm.Way.load(Way.java:197)
at org.openstreetmap.josm.command.Command.undoCommand(Command.java:94)
at org.openstreetmap.josm.command.SequenceCommand.undoCommands(SequenceCommand.java:76)
at org.openstreetmap.josm.command.SequenceCommand.undoCommand(SequenceCommand.java:81)
at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:72)
at org.openstreetmap.josm.actions.UndoAction.actionPerformed(UndoAction.java:34)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (1)

comment:1 Changed 10 years ago by mjulius

Resolution: fixed
Status: newclosed

(In [2683]) fixes #4149 - exception when undoing reversal of way with tag corrections

don't try to undo Command for a primitive that does not belong to a dataset

fixes issue with ChangeRelationMemberRoleCommand.undoCommand() doing nothing except resetting modified flag
don't reverse tags on way nodes when reversing way
reversing way now also reverses 'incline=*' tags

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.