Modify

Opened 12 years ago

Closed 12 years ago

#4120 closed enhancement (fixed)

[Patch] Orthogonalize action will no longer orthogonalize multiple areas if they are "not facing the same way"

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: orthogonalize Cc:

Description

The orhtogonalize action used to orthogonalize multiple selected ways even if they weren't aligned in the same way, which was convenient as you could just select multiple houses and then orthogonalize them, and the action would orthogonalize them one by one. Now I would have to select dozens of houses one by one and the orthogonalize each separately, whereas previously I could just select them all and then orhtogonlaize all at the same time.

Attachments (1)

OrthogonalizeGroups.patch (2.7 KB) - added by mjulius 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by bastiK

Keywords: orthogonalize added
Type: defectenhancement

This is not a bug it's a feature: Often you have a group of buildings that are headed in the same direction.

Is it really that time consuming to click the buildings one by one and press 'Q' after each selection?

comment:2 in reply to:  1 Changed 12 years ago by mjulius

Replying to bastiK:

Is it really that time consuming to click the buildings one by one and press 'Q' after each selection?

I guess it can be.

How about doing an individual orthogonalize by default and do a group orthogonalize only when there are two nodes selected or with 'Shift-Q' or so?

comment:3 Changed 12 years ago by bastiK

The problem are different ways that have common nodes. (E.g. for terraced houses)
You cannot orthogonalize these separately. Then the logical solution would be to orthogonalze each group of connected ways separately. Patches are welcome! :)

comment:4 Changed 12 years ago by mjulius

Summary: Orthogonalize action will no longer orthogonalize multiple areas if they are "not facing the same way"[Patch] Orthogonalize action will no longer orthogonalize multiple areas if they are "not facing the same way"

Here you go.

With this patch JOSM will behave the same as it is now if two nodes are selected together with one or more ways. If no nodes are selected, it groups the selected ways into ways that share at least one node. That is, each way in each group shares at least one node with another way in that group. Then, each group is orthogonalized separately

Also, each orthogonalized group shows up separately in the Command Stack. I am not quite sure whether this is desired behavior.

Changed 12 years ago by mjulius

Attachment: OrthogonalizeGroups.patch added

comment:5 Changed 12 years ago by bastiK

Resolution: fixed
Status: newclosed

(In [2596]) fixed #4120 (patch by mjulius) - orthogonalize tool: Do not assume all selected areas are facing in the same direction

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.