[Patch] Orthogonalize action will no longer orthogonalize multiple areas if they are "not facing the same way"

[anonymous]

The orhtogonalize action used to orthogonalize multiple selected ways even if they weren't aligned in the same way, which was convenient as you could just select multiple houses and then orthogonalize them, and the action would orthogonalize them one by one. Now I would have to select dozens of houses one by one and the orthogonalize each separately, whereas previously I could just select them all and then orhtogonlaize all at the same time.

[bastiK]

This is not a bug it's a feature: Often you have a group of buildings that are headed in the same direction.

Is it really that time consuming to click the buildings one by one and press 'Q' after each selection?

[mjulius]

Replying to bastiK:

Is it really that time consuming to click the buildings one by one and press 'Q' after each selection?

I guess it can be.

How about doing an individual orthogonalize by default and do a group orthogonalize only when there are two nodes selected or with 'Shift-Q' or so?

[bastiK]

The problem are different ways that have common nodes. (E.g. for terraced houses)
You cannot orthogonalize these separately. Then the logical solution would be to orthogonalze each group of connected ways separately. Patches are welcome! :)

[mjulius]

Here you go.

With this patch JOSM will behave the same as it is now if two nodes are selected together with one or more ways. If no nodes are selected, it groups the selected ways into ways that share at least one node. That is, each way in each group shares at least one node with another way in that group. Then, each group is orthogonalized separately

Also, each orthogonalized group shows up separately in the Command Stack. I am not quite sure whether this is desired behavior.

[bastiK]

(In [2596]) fixed #4120 (patch by mjulius) - orthogonalize tool: Do not assume all selected areas are facing in the same direction