[PATCH] auto-weld

[Ben]

Please can there be an option to tern auto weld off? Some may have a use for it, but I havn't met them! Thanks.

(by auto-weld I mean when you 'insert a node' into 2 close by ways, they both get effected.

It may be better to only have it happen when holding shift or something?

[anonymous]

See: ​http://lists.openstreetmap.org/pipermail/josm-dev/2007-October/000033.html

[Ben]

I had read that previously. The problem is that 99% of the time you don't want to weld, and a tiny percentage of the time you do. Different editors may disagree, but the next point applies to all:

If auto-weld is the default and shift is used to stop it then you would commonly 'click, ctrl-z, shift click, as you would only hold shift after reverting as you see that its welded. Thats 5 keys for 1 common job, 1 click for 1 rare job.

[xeen]

We don't have any modifier keys left (CTRL don't connect, SHIFT new way). We could

• Add it as a preference
• Drop shift (not sure the new "doubleclick to finish" is an equal replacement)

IF we drop shift, should it be default-off? Apart from fixing overlapping streets (typical novice mistake) I can't think of any use for auto-weld. It doesn't help novice either because it's very unlikely that they create overlapping streets and then connect a 3rd way/street there.

[xeen]

Ticket #474 has been marked as a duplicate of this ticket.

[xeen]

• SHIFT is now "turn off node reuse" instead of "turn off connection"
• Double clicking/clicking last node again now finishes drawing even if potlatch style drawing is disabled
• ALT key + insert new node in selected way does not produce "bad" selection anymore
• Reworked status line help texts
• a bit of refactoring to make mouseClicked() easier to read

[xeen]

Found and fixed null pointer exception. Otherwise the same.

[stoecker]

Applied in r1438.