#3791 closed enhancement (wontfix)
[PATCH] nicer upload dialog
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | upload gui | Cc: |
Description
I find the current upload dialog a bit confusing so I decided to do my first development on JOSM. The patch rearranges some parts of the upload dialog. No functionality changes so far.
I've also attached a screenshot of the new dialog so you can have a look without applying the patch.
Any comments welcome.
What I'd like to see in the future is, that if the upload is done with an existing changeset the comment of the changeset is taken and not the comment of the upload dialog. If someone wants to change the comment he can do this on the changeset tab. Reason: When multiple changesets are open it is confusing if you have to change both the changeset and the comment before uploading. If you forget to change the comment in the dialog the comment of the changeset is changed silently.
Andre
Attachments (3)
Change History (7)
by , 15 years ago
| Attachment: | new-upload-dialog.diff added |
|---|
comment:1 by , 15 years ago
A solution would be: Preselect current comment for open changesets instead of last one.
comment:2 by , 15 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
I'd rather not apply your patch. The suggested new layout isn't better than the current one. In particular it suggest that an upload comment can be entered for a new changeset only, which is not the case: it should always be entered. If you upload to an existing changeset it should be possible to update the update comment.
comment:3 by , 15 years ago
Well, as I said the patch is an enhancement and I think that some more changes need to be done.
The current dialog is not good since you can not see the comment for the open changesets unless you make the dialog very wide which causes the layout manager to rearrange the upper part of the dialog so that in some cases (with some window heights) you cannot see, what changes you are going to upload. Will attach a screenshot of a bad window here so that you can have a look.
And as I already said I find it very confusing changing both the changeset and the comment if I want to upload something and have multiple open changesets. Thus, I think that the comment should be entered when opening the changeset with the ability to change the comment on the changeset tab. The current behaviour suggests that the user can change the comment for each change which is not the case. Only one comment for the changeset is possible.
Next step for this purpose would be to disable the comment line if an open changeset is used.
Will shift this discussion to the mailing list this afternoon to hear what other developers/users think about it...
by , 15 years ago
| Attachment: | old-upload-dialog.png added |
|---|
Old upload dialog box with invisible changes
comment:4 by , 15 years ago
For what it's worth I've uploaded at least 3 changesets with the wrong comment=* because I was managing multiple open changesets at once and the design of the old upload dialog was such that when fiddling with it I managed to accidentally overwrite the comment on the server with another local comment.
This new dialog makes a much better use of available space. However existing upload comments should also be easy to change, just not so easy that one can do it accidentally.
The upload ui patch