Modify

Opened 12 years ago

Closed 12 years ago

#3738 closed defect (fixed)

[Patch] Searching for non-existent usernames returns objects submitted by anonymous users

Reported by: avarab@… Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

If I search for "user:THISUSERDOESNOTEXIST" in data that includes objects submitted by anonymous users (example) JOSM will highlight the data submitted by the anonymous user.

Example XML for anonymous user data:

<node id="14581959" lat="64.0552442" lon="-21.9693467" version="1" changeset="99570" visible="true" timestamp="2006-08-31T20:18:45Z">
  <tag k="created_by" v="JOSM"/>
</node>

If the search engine is to support searching for anonymous user data it would be better to do so in a way that the data isn't returned when the user makes a type in a regular username. E.g. by searching for:

user:<anonymous>

or:

uid:0

Or something similar to that

Attachments (2)

anon-user.osm (132.1 KB) - added by avarab@… 12 years ago.
.osm file with anonymous user data
SearchAnonymousUser.patch (2.4 KB) - added by mjulius 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by avarab@…

Attachment: anon-user.osm added

.osm file with anonymous user data

comment:1 Changed 12 years ago by mjulius

Summary: Searching for non-existent usernames returns objects submitted by anonymous users[Patch] Searching for non-existent usernames returns objects submitted by anonymous users

The attached patch adds "user:anonymous" as a special search. And, searches for non-existent users will not return anything anymore.

This assumes that user 'anonymous' will not show up in real data. This user exists on the API server. However, since he has made no edits in over 2 years I believe it is very unlikely he will suddenly come back.

Changed 12 years ago by mjulius

Attachment: SearchAnonymousUser.patch added

comment:2 Changed 12 years ago by Gubaer

Resolution: fixed
Status: newclosed

(In [2567]) applied #3738: patch by mjulius: Searching for non-existent usernames returns objects submitted by anonymous users

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.