Opened 15 years ago

Closed 15 years ago

#3565 closed defect (fixed)

[PATCH] Typo and string unification for exceptions

Reported by: Claudius Owned by: stoecker
Priority: minor Milestone:
Component: Core Version:
Keywords: Cc:


Please find attached a larger patch with unifications for exception strings. Mainly it's uppercasing the first character. I understand that you might not want to apply the full patch as it would result in large parts of translations being redone.

If you don't apply the full patch please fix the typo in

  • throwException(tr("illegal nummeric value for attribute {0}. Got {1}", "id", id));

+ throwException(tr("Illegal numeric value for attribute {0}. Got {1}", "id", id));

Attachments (2)

typo_and_unification.diff (14.2 KB ) - added by Claudius 15 years ago.
typo_and_unification_reloaded.diff (41.1 KB ) - added by Claudius 15 years ago.

Download all attachments as: .zip

Change History (5)

by Claudius, 15 years ago

Attachment: typo_and_unification.diff added

comment:1 by stoecker, 15 years ago

Owner: changed from team to Claudius
Status: newneedinfo

No problem applying it, but please be consistent.

  • All these strings should be uppercase then - you again separated equal strings. (LANG=en grep "tr(\"[a-z]" -r src)
  • All ", got" should be ". Got".
  • Add dots at end of sentences.

I will take care of the translation updates so the translations don't get lost.

by Claudius, 15 years ago

comment:2 by Claudius, 15 years ago

Owner: changed from Claudius to stoecker
Status: needinfonew

(It all started with a simple typo to fix...)

I've manually skimmed through all files in org/openstreetmap/josm/io/ and applied the valid remarks you had. You can find it in the typo_and_unification_reloaded.diff file that is attached

comment:3 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

In r2181 with lots of other changes.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.