Modify

Opened 13 years ago

Closed 13 years ago

#3522 closed defect (fixed)

Wrong changeset comment when uploading data

Reported by: anonymous Owned by: team
Priority: critical Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

I uploaded two times today, everytime I changed the comment for the changeset, but both times the comment text of an earlier upload was used. Both comment texts are available via the combo box. Looking at my changesets from yesterday the same happened to them, everytime an earlier comment text was uploaded instead of the one entered by me.

Attachments (0)

Change History (7)

comment:1 Changed 13 years ago by Erik

If the upload comment is changed, this won't apply until JOSM is restarted (which is bad).

I'm not sure if the problem is this, but shouldn't UploadDialog.getUploadComment() return something when tab 0 is selected (org/openstreetmap/josm/gui/io/UploadDialog.java)?

comment:2 Changed 13 years ago by t-i

Same problem here! The changeset-comment isn't correctly added
http://www.openstreetmap.org/user/t-i/edits

2502483 should be "St. Urban Cleanup"
2502544 should be "Changeset Test"

"Witikon nord" is a Comment from yesterday that obviously was not added to the changeset.

comment:3 Changed 13 years ago by t-i

My Version: 2143

comment:4 Changed 13 years ago by Ldp

I had the same in 2127.

  • Open and close a changeset with comment A.
  • Open another, edit, upload with comment B, but leave the changeset open.
  • Edit some more, upload again into the open changeset. This time the comment gets updated to B.

From a short conversation on IRC just now, someone told me he had this too, but he didn't keep the 2nd changeset open, so now the previous comment is on it, and it cannot be changed anymore.

comment:5 in reply to:  4 Changed 13 years ago by ray.foulkes@…

Replying to Ldp:
It is worse than that, if you do not have a previous comment it is impossible to do an upload even if you put a comment in. I just raised a ticket about this total block. This in latest 2143.

comment:6 Changed 13 years ago by ray.foulkes@…

I should have added the ticket number 3530

comment:7 Changed 13 years ago by Gubaer

Resolution: fixed
Status: newclosed

(In [2148]) fixed #3530: Unable to satisfy "Please enter a comment....(min 3 chars..)"
fixed #3522: Wrong changeset comment when uploading data

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.