[PATCH] reinsert one line that was deleted with r2039

[bastiK]

This part of [2039]:

-                                    manifest = null;
+                                    // Is null anyway
+                                    //manifest = null;

needs to be reverted because strange things happen now.

[Gubaer]

The patch is not necessary. manifest = null is redundant at this position (at least that's what eclipse tells me)

[bastiK]

Eclipse seems to be pretty smart. However that does not solve the problem. :)

How to reproduce:

• open preferences dialog
  
• load some plugins (if you haven't done so already)
  
• the following text is printed over and over to the console:

  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Ant-Version.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Created-By.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Author.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Plugin-Class.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Plugin-Date.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Plugin-Mainversion.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  WARNING: Duplicate name in Manifest: Plugin-Version.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.
  Sep 4, 2009 8:12:23 PM java.util.jar.Attributes read
  ...
  

(r2054, complied with Sun Java 1.5 on Ubuntu hardy)

[stoecker]

(In [2056]) close #3392

[stoecker]

Eclipse is faulty here. It does not correctly detect side effects inside the for loop. The assumption that manifest is null will usually be wrong after the first for loop has been done (or BTW the whole function would be useless).

Do not rely to much on automated logic. It is faulty too often.