Fatal freeze trying to enter a changeset comment

[Claudius]

How to reproduce:
Prerequisite: Have some changesets uploaded with comments before

• Try to upload a changeset
• Delete the prefilled changeset comment
• Enter The first letter of a previously used changeset comment

Result:

• Complete UI freeze
• Java VM CPU usage peaks to 100%
• Java VM memore usage peaks to all available memory

(I was using farsi UTF8 characters in some of the changeset comments. Not sure if this is related.)

Version 2021 - Present in last tested rev 1981 as well
Plugins:
waydownloader 16963
wmsplugin 17278
remotecontrol 16965

[Gubaer]

sound like #2542 which has been fixed months ago.

What's your environment? OS? WM? Java VM?

[Gubaer]

Is this related to #2747? Are you working with russian characters?

[Claudius]

WindowsVista 64bit
Sun Java 1.6.0_15

Unfortunately I cannot kill the locked/looped JOSM to get more information. What I tried was starting JOSM from cmd and hitting Ctrl+Break with the frozen JOSM window focussed which did nothing.

I've been using farsi (similar to arabic script) characters in my comments before.

[Claudius]

Deleting upload.comment.history in my JOSM Preferences "solved" this issue for me.

I'm attaching the content of this line here so you can reproduce. I think this bug is a major issue as it's affecting all those emerging OSM regions that are using UTF-8.

[Claudius]

faulty line of JOSM preferences

[stoecker]

Ticket #3136 has been marked as a duplicate of this ticket.

[katpatuka]

confirmed. I had the same problem with Thai characters in the comment field - after deleting upload.comment.history no freezing anymore.

[katpatuka]

josm debug output when editing relation with Thai characters

[jttt]

I can confirm the freeze with java 1.6.0_15 and faulty_upload_comment_history

[jttt]

It looks like freeze is caused by EventConsumingPlainDocument in SuggestingJHistoryComboBox. When I don't enable consuming events then josm doesn't freeze.

[stoecker]

Can't we replace the comment history with the AutoComplete code, so we don't have two places with equal code?

[jttt]

I didn't know we have two autocompletion combos. I think they can be merged, SuggestingJHistoryComboBox has some extra features (or rather convenience methods) but AutoCompleteComboBox works fine with multilanguagual texts (tested on faulty_upload_comment_history)

[stoecker]

What extra stuff does SuggestingJHistoryComboBox have?

AutoComplete has one problem with multi-sign input methods. There is a bu report about this. But otherwise it works very good after the last rework I did (which was a very hard job to get all working as expected).

[Gubaer]

(In [2218]) see #3371: Fatal freeze trying to enter a changeset comment

[Gubaer]

I've removed SuggestingJHistoryComboBox. It's replaced by a HistoryComboBox which combines the features of AutoCompletionComboBox wit the features of the ComboBoxHistory.

In my env, JOSM doesn't freeze any more with the faulty upload comment history.

[Claudius]

Played around a bit and it seems to be fixed finally in v2221. Thanks a lot.