Modify

Opened 10 years ago

Closed 10 years ago

#3352 closed enhancement (fixed)

History doesn't get invalidated on upload?

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: history primitive Cc:

Description

Hi, I tried out the new history dialog and it looks promising. One thing that I did was look at the history of a way, delete a tag on that way, upload it and then look at the history again. It did not change (the new version was not shown). I tried the refresh button in the history dialog to no avail. After doing this for some time, I gave up and started a fresh josm. It immediately showed the full history.

So I wonder if the history information that is cached for a way/node/etc. is not being invalidated if that element is uploaded?

Using 1992.

Thanks

Attachments (0)

Change History (3)

comment:1 Changed 10 years ago by Gubaer

Resolution: fixed
Status: newclosed

In r2019 you can reload the history of a primitive in its history browser dialog. The cache is not automatically invalidated when a primitive is upload, though. You have to manually reload it.

comment:2 Changed 10 years ago by vsandre

Keywords: history primitive added
Resolution: fixed
Status: closedreopened
Type: defectenhancement
Version: testedlatest

The reloading of the history is fixed. But the problem anonymous named is still the same.

Could you add the current version of the primitive to the history dialogue instead of showing only the API history?

  1. If the data is downloaded, the latest version in the history is the same as the version in the dataset. Latest revision should marked as active.
  2. Primitive is changed in the JOSM dataset (see action='modify'), a new line should be showed. It must be possible to see which version the changing is based on for the case the primitive is changed in the meantime.
  3. If the primitive was changed and uploaded the history dialogue should show the version in the dataset as new line with its new revision number.

See the example, that all information is in the JOSM dataset.

Downloaded way: version='3'

<osm>
  <way id='22376651' timestamp='2009-08-06T13:37:26Z' user='vsandre' visible='true' version='3'>
    <nd ref='30324496' />
    <nd ref='240565095' />
    <nd ref='240565091' />
    <nd ref='240565089' />
    <nd ref='240565084' />
    <nd ref='240565082' />
    <nd ref='240565079' />
    <nd ref='240565074' />
    <nd ref='240565071' />
    <nd ref='240565067' />
    <nd ref='240565064' />
    <tag k='highway' v='footway' />
    <tag k='bicycle' v='yes' />
  </way>
</osm>

Modified way: action='modify' version='3'

<osm>
  <way id='22376651' action='modify' timestamp='2009-08-06T13:37:26Z' user='vsandre' visible='true' version='3'>
    <nd ref='240565064' />
    <nd ref='240565067' />
    <nd ref='240565071' />
    <nd ref='240565074' />
    <nd ref='240565079' />
    <nd ref='240565082' />
    <nd ref='240565084' />
    <nd ref='240565089' />
    <nd ref='240565091' />
    <nd ref='240565095' />
    <tag k='highway' v='footway' />
    <tag k='bicycle' v='yes' />
  </way>
</osm>

Uploaded way: version='4'

<osm>
  <way id='22376651' timestamp='2009-08-06T13:37:26Z' user='vsandre' visible='true' version='4'>
    <nd ref='240565064' />
    <nd ref='240565067' />
    <nd ref='240565071' />
    <nd ref='240565074' />
    <nd ref='240565079' />
    <nd ref='240565082' />
    <nd ref='240565084' />
    <nd ref='240565089' />
    <nd ref='240565091' />
    <nd ref='240565095' />
    <tag k='highway' v='footway' />
    <tag k='bicycle' v='yes' />
  </way>
</osm>

If the changes for this enhancement are to big to do it immediately, please add a note that the history is outdated if the primitive is changed.

comment:3 Changed 10 years ago by Gubaer

Resolution: fixed
Status: reopenedclosed

(In [2448]) fixed #3352: History doesn't get invalidated on upload?
fixed #3912: Extend history dialog to contain the currently modified version
new: zoom to node in list of nodes in history dialog (popup menu)
new: load history of node from node list in history dialog (popup menu or double click)
fixed: close all history dialogs when the number of layers drop to 0
fixed: implemented equals() and hashCode() on SimplePrimitiveId
fixed: history features now usePrimitiveId instead of long.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.