Modify

Opened 12 years ago

Closed 12 years ago

#2892 closed enhancement (fixed)

[PATCH] Add shortlink support to download dialog

Reported by: avarab@… Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: download, shortlink, patch Cc:

Description

Pasting a normal permalink from osm.org works, but the new shortlink syntax isn't supported.

Here's the ruby code that does the decoding: http://trac.openstreetmap.org/browser/sites/rails_port/lib/short_link.rb

Attachments (1)

shortlinks.patch (4.5 KB) - added by plaicy 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by plaicy

Attachment: shortlinks.patch added

comment:1 Changed 12 years ago by plaicy

Patch created. Put it is not nice: zoom levels does not fit (there is a "-2" workaround in code).

The shortlink feature is not designed very well: "@" in urls are not a good idea because they have to be escaped. Even if they are escaped the official server does not decode them:
see http://osm.org/go/aa@@@odHv--
this shortlink is created at this permanent link http://www.openstreetmap.org/?lat=14.057645&lon=-22.502361&zoom=18

comment:2 Changed 12 years ago by avarab@…

Keywords: patch added
Summary: Add shortlink support to download dialog[PATCH] Add shortlink support to download dialog

comment:3 Changed 12 years ago by stoecker

Resolution: fixed
Status: newclosed

(In [2540]) applied #2892 - patch by plaicy - added osmgo shortlink support to url decoder

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.