Opened 16 years ago
Closed 16 years ago
#2755 closed defect (fixed)
[PATCH] data error caused by duplicate node fix applied outside of the downloaded area
| Reported by: | Harry Wood | Owned by: | dmuecke |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core validator | Version: | latest |
| Keywords: | Cc: | delta_foxtrot@… |
Description
When you validate data which is outside of the downloaded area the plugin allows you to "fix" this data, which can cause nasty data errors ("dataset violates a precodition" when you try to upload)
You can reproduce this within the TIGER data along county boundary roads where there are a lot of duplicate nodes. Try to fix a node which has other (not downloaded) roads connected to it.
How to fix this though?
The plugin defaults to validating all downloaded data including data outside the downloaded area. Maybe this is wrong. Maybe it should only validate nodes within the downloaded area. Or maybe it should only allow fixing within the downloaded area. Or maybe for the duplicate nodes fix, it should give a warning similar to the message which appears if you try to delete a node outside the downloaded area (try it)
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|
comment:2 by , 16 years ago
| Cc: | added |
|---|
by , 16 years ago
| Attachment: | duplicate.txt added |
|---|
comment:3 by , 16 years ago
| Summary: | data error caused by duplicate node fix applied outside of the downloaded area → [PATCH] data error caused by duplicate node fix applied outside of the downloaded area |
|---|
comment:4 by , 16 years ago
| Status: | new → assigned |
|---|
Any reason why this patch isn't merged into JOSM?
comment:5 by , 16 years ago
| Status: | assigned → new |
|---|
Send dmuecke an email with instructions on how to apply the patches to the plugins, build the new plugins, and deploy them.
I've added a dialog box to warn users before merging nodes outside downloaded area as recommended.