Opened 4 weeks ago
Last modified 3 days ago
#24924 new enhancement
[patch] Remove Junit 4 last remains
| Reported by: | gaben | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 26.11 |
| Component: | Unit tests | Version: | |
| Keywords: | junit4 | Cc: |
Description
While working on some patches, I noticed that IntelliJ still has ancient Junit4 files on the classpath. I therefore started removing them completely from the core.
I only focused on the core, the core plugins still have to be checked.
FYI: There is an existing ticket for Junit 6 migration (#24921).
Attachments (1)
Change History (3)
comment:1 by , 3 days ago
by , 3 days ago
| Attachment: | 24924.patch added |
|---|
comment:2 by , 3 days ago
| Milestone: | → 26.11 |
|---|---|
| Summary: | Remove Junit 4 last remains → [patch] Remove Junit 4 last remains |
Beware, the patch introduces deprecations, but it should ultimately be leaner and cleaner for everyone in the long term.
Some adjustments will probably be needed.
Changes:
- removed all references to JUnit 4 (dropped
junit-vintage-engine,junit-jupiter-migrationsupport),JOSMTestRulesnow runs on plain Jupiter callbacks - build cleanup:
- removed the unused
commonslang/errorprone_javacivy confs and thejavacc.homeproperty, - fixed the jdeps "all" graph and standalone
ant extract-libraries, and - synced
commons-lang3between Ant and Maven.
- removed the unused
- josm-custom.jar no longer bundles
commons-lang3and Jetbrains annotations; the sources jar now shipsjakarta.annotation-api3.0.0 sources, matching the classes. - tests no longer write
foobar/orfailed.pnginto the working copy (#23090) PluginHandlerJOSMTooOldTestno longer fails on my machine withhu_HUlocale. The expected strings were built before the test switched the locale to English, so they had the wrong thousands separator.



Also #23090 should be fixed with the changes.