Remove Inkscape-specific content from amenity=bench

[mkoniecz]

Some SVG files have files saved not in plain SVG but in Inkscape variant of SVG.

This can be fixed for example by opening file in SVG and saving it as "plain svg".

Note that current unwanted Inkscape (proprietary) mess is (at least for me on Inkscape 1.4.4) causing issues, with "Convert legacy Inkscape file" dual popup opening on each opening and not doing any conversion.

Saving file as proper svg fixes the problem.

[mkoniecz]

probing patch for amenity=bench icon

[mkoniecz]

In other projects that were using SVG norm was to treat this Inkscape extensions as unwanted trash and to prefer/enforce plain SVG.

If keeping that Inkscapeisms - what can be done to shut up "Convert legacy Inkscape file" dual popups?

Bump inkscape:version="0.91 r13725" ? (according to my check JOSM use case does not actually require changes on 90 to 96 dpi migration, only marking that no migration is needed)

[mkoniecz]

For reference: I just file upstream bugs

​https://gitlab.com/inkscape/inbox/-/work_items/13860 "Convert legacy Inkscape file" is not doing conversion

​https://gitlab.com/inkscape/inbox/-/work_items/13859 ​https://inkscapesoftware.com/community/ has broken links - open the chat room button opens dead "​https://download3.frapdownload.org/library_set.zip"

while trying to fix the problem.

[stoecker]

These are development files and not released as they are (have a look into the JAR's to compare). There is no reason to strip such information from devel files.

[mkoniecz]

how else these "Convert legacy Inkscape file" dual popups on opening this file can be fixed ?

[stoecker]

When you edit the file convert them. Or strip them before with svgcleaner. If you edit the file it anyway will be different later :-)

[mkoniecz]

in this case I have no need to edit actual content - wanted to take look at how proper icon is build

I guess I could make fake edit, revert it and hope that will result in Inscape shutting up? Would such patch be accepted?

[stoecker]

I don't understand why do you want to submit this? The icons are as they have been made at the time when they were made. Software metadata changes (because it is not standardized), but that's not really relevant for the image itself as this is stripped anyway. But when you want to edit it, then inkscape wants to convert to the newest type of metadata. Otherwise it is not relevant.

Stripping the image throws away a lot of information not relevant for display, but probably relevant for future editors (groups, names, ...), so we do not strip the images in SVN, but only when releasing.

And I don't think the JOSM icons are "proper icons". Some of them are overly complex. The only rule for JOSM is, that they work :-)

[wangi]

Replying to mkoniecz:

in this case I have no need to edit actual content - wanted to take look at how proper icon is build

I guess I could make fake edit, revert it and hope that will result in Inscape shutting up? Would such patch be accepted?

I assume you are wanting to use the JOSM icons in another project?

They are not used as-is, the build process strips, minifies and whatever. What ends up being loaded into JOSM is totally stripped to the bone. Take the josm-tested.jar from the home page, rename it to josm-test.zip, extract and look in the images directory. For example images/presets/leisure/bench.svg:

<svg height="6" viewBox="0 0 16 6" width="16" xmlns="http://www.w3.org/2000/svg"><g fill-rule="evenodd"><g fill="#e6e6e6"><rect height="3" ry=".5" width="16"/><rect height="4" ry=".5" width="3" x="2" y="2"/><rect height="4" ry=".5" width="3" x="11" y="2"/></g><rect height="1" ry=".5" width="14" x="1" y="1"/><rect height="4" ry=".5" width="1" x="3" y="1"/><rect height="4" ry=".5" width="1" x="12" y="1"/></g></svg>

[mkoniecz]

I assume you are wanting to use the JOSM icons in another project?

no, I am trying to make JOSM patch, also icon-related. Specifically to fix #24740 and went looking through other JOSM icons to see how to do it properly

on opening for example this bench icon Inkscape spams about need to upgrade it from older Inkscape version which is annoying (made worse by Inkscape having bugs in handling of that)

I don't understand why do you want to submit this?

I want to stop getting this annoying Inkscape modals, and (1) I thought that it would be preferred by others, so contributing it back to JOSM would be useful (2) I do not want to maintain personal JOSM fork.

And I don't think the JOSM icons are "proper icons". Some of them are overly complex. The only rule for JOSM is, that they work :-)

well, fully white icon for lounger is not passing even that threshold for now