Modify ↓

Opened 7 weeks ago

Last modified 15 hours ago

#24876 new enhancement

[patch] Improve PowerLines test performance

Reported by: gaben Owned by: team
Priority: normal Milestone: 26.09
Component: Core validator Version:
Keywords: Cc: GerdP

Description

While working on #24851, I discovered some inefficiencies. In my tests, I managed to make the test run approximately 8 times faster.

I'll work on the patch to make sure nothing broke, because I'm a bit suspicious.

The patch will follow soon. Ping me if I forget.

Attachments (1)

24876-v2.patch​ (7.2 KB ) - added by gaben 15 hours ago.

Download all attachments as: .zip

Change History (3)

by gaben, 15 hours ago

Attachment: 24876-v2.patch​ added

comment:1 by gaben, 15 hours ago

Summary: Improve PowerLines test performance → [patch] Improve PowerLines test performance

Something like this. Avoiding the per-node evaluation of findCrossings() gives an 8x performance increase on my test data with the same output.

There are also some memory allocation improvements.

Last edited 15 hours ago by gaben (previous) (diff)

comment:2 by gaben, 15 hours ago

Milestone: → 26.09

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to gaben.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.