Modify

Opened 16 years ago

Closed 15 years ago

#2484 closed defect (worksforme)

poor performance with relation editor dialog

Reported by: elyk Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

After opening the relation editor dialog a few times, performance takes a nosedive. In particular, performance seems fine until a certain point whereafter it takes a long time to draw any dialog box on the screen. Opening the relation editor dialog a few times triggers the behavior.

I've tried running top to investigate exactly when this problem happens. Opening the relation editor dialog will cause the virtual memory size (VIRT column) to increase by about 4m or 5m each time I open it. If I run java -Xmx768m -Dsun.java2d.opengl=true -jar ./josm-latest.jar then the performance tanks when the VIRT column reaches about 1024m.

I've tried changing the -Xmx option to 512m and 1024m. The problem happens when the VIRT column gets to about 768m and 1280m, respectively. In all cases, that's about 256m above the value I give for -Xmx.

What can be done about this? Can the relation dialog be improved to not gobble up 4 or 5 megabytes of virtual memory every time it is opened?

$ java -version
java version "1.6.0_06"
Java(TM) SE Runtime Environment (build 1.6.0_06-b02)
Java HotSpot(TM) Client VM (build 10.0-b22, mixed mode, sharing)

Attachments (0)

Change History (3)

comment:1 by anonymous, 16 years ago

Not reproducible under Windows XP & JRE 5.0_18 using REV SVN rev 1569.

When you are talking about "Opening the relation editor dialog a few times" do you mean open and cancel/abort or opening and save the relation? Because if you save the relation the memory loss may be caused by the undo operation that saves the previous relation version.

Besides that it does not hurt to add the following line to the RelationEditor constructor:

setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

in reply to:  1 comment:2 by elyk, 16 years ago

Replying to anonymous:

Not reproducible under Windows XP & JRE 5.0_18 using REV SVN rev 1569.

I don't know if it matters or not, but I'm using Slackware 12.1.

When you are talking about "Opening the relation editor dialog a few times" do you mean open and cancel/abort or opening and save the relation? Because if you save the relation the memory loss may be caused by the undo operation that saves the previous relation version.

I mean open and cancel.

comment:3 by Gubaer, 15 years ago

Resolution: worksforme
Status: newclosed

Can't reproduce. Closing.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.