[patch] rotate does not work under Mac OS X

[dressman]

The rotate command (crtl-shift + mouse movement) does not work; the mouse pointer changes, but the rotation does not take place. JOSM 1555 and 1529, Mac OS X 10.5.6/PPC, Java 1.5.0_16-133

[anonymous]

We have OS specific classes to catch this stuff. Please use these instead of writing OS specific code directly into the target class.

[dmuecke]

Thanks for the advice but I can't find a good example in class PlatformHook.
Can I use something like if exists Main.pref.get("activate-mousemove") then ... ?

[stoecker]

Ok, I had a deeper look. Actually it seems only the check whether that code is executed or not must be moved to plattform hook. So add a function boolean useActiveMouseMove() to the plattform stuff and replace the OS-check with it.

[dmuecke]

rotate patch + platform hook

[stoecker]

In r1634.

[taylor.smock]

In 18767/josm:

Fix #23015, see #2483: Right click (map move) + scale/rotate modes should not interfere with each other

The workaround added for #2483 (r1634, Java 5) does not appear to be needed
anymore (tested with a Magic Mouse in one-button mode under Java 8). Removing
the workaround fixes the behavior whereby a right-click will cause the
scale/rotate mode to be enabled.

To fix extraneous commands being generated during a map pan when scale/rotate
mode is enabled, we check to see if the right mouse button is down in
updateCommandWhileDragging.