Opened 7 weeks ago
Last modified 3 weeks ago
#24829 needinfo enhancement
Add comments to reverted changesets
| Reported by: | Fizzie-DWG | Owned by: | Fizzie-DWG |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin reverter | Version: | tested |
| Keywords: | Cc: |
Description
When doing reverts in iD via osm-revert (https://revert.monicz.dev/), it gives the option of adding comments to the reverted changeset e.g. https://www.openstreetmap.org/changeset/184893658
This is extremely helpful to show that problem edits have already been reverted, so would it be possible to introduce similar functionality into JOSM reverts?
Attachments (0)
Change History (7)
follow-ups: 3 5 comment:1 by , 7 weeks ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
comment:2 by , 6 weeks ago
It would be nice to have the comment automatically added on upload, especially when you're reverting multiple changesets. Having to manually go to the changeset page and add the comment there separately is a bit cumbersome.
This enhancement would streamline the process a little bit. It would also make it less likely that someone forgets to notify others about the revert of the changeset.
comment:3 by , 3 weeks ago
Replying to stoecker:
Where is the problem? When you revert something and upload it, you can add a comment.
Sorry, didn't see your comment.
As Woazboat said, when you're reverting multiple edits at once (& for DWG, that can be hundreds!), adding a comment to each CS is impractical, where being able to automatically add the same comment to each of them would be great. Very helpful fro other Users as well, as they can immediately see that that CS has already been reverted.
comment:4 by , 3 weeks ago
You know that you can revert multiple edits in one go using the reverter plugin?
comment:5 by , 3 weeks ago
Sounds like misunderstanding.
Replying to stoecker:
Where is the problem? When you revert something and upload it, you can add a comment.
Yes, I can add a comment to the changeset which reverts the changesets but to comment on the reverted changesets, I manually have to add a comment to each of them.
Replying to GerdP:
You know that you can revert multiple edits in one go using the reverter plugin?
Yes. This is the case. I revert 20 changesets in one go but then I have to manually comment on each reverted changeset.
So the feature request is to offer to automatically add an identical comment to each reverted changeset after (within) a successful upload of reverts.
follow-up: 7 comment:6 by , 3 weeks ago
Thanks for the clarification. I see one problem here: The current behaviour is that you can use the reverter plugin and then continue editing and later decide to throw away all changes. So, at what point in time would it be feasible to show the request? Maybe only if the command stack contains exactly one action created by the reverter?
comment:7 by , 3 weeks ago
Replying to GerdP:
So, at what point in time would it be feasible to show the request?
Good question.
From a user's point of view, I thought this new feature would be nice within the upload dialog and comments would be uploaded after an successful data upload.
Now, looking from the coder's side, I understand that it gets tricky and I am not sure if the upload dialog can be expanded by a plugin and if it is feasible to upload comments on changeset from there.



Where is the problem? When you revert something and upload it, you can add a comment.