[WIP patch] Add placement info to highway=passing_place preset

[gaben]

I'd like to add the placement info to the highway=passing_place preset.

Unfortunately, the following patch does not work as I want it to:

resources/data/defaultpresets.xml

@@ -1619 +1619 @@
         <item name="Passing Place" icon="presets/vehicle/passing_place.svg" type="node" preset_name_label="true">
             <link wiki="Tag:highway=passing_place" />
             <key key="highway" value="passing_place" />
+            <optional>
+                <combo key="passing_place" text="Placement in way direction" values="left,right,both" values_sort="false" />
+            </optional>
             <preset_link preset_name="Emergency Bay" text="Similar but different tags:"/>
         </item> <!-- Passing Place -->
         <item name="Emergency Bay" icon="presets/vehicle/emergency_bay.svg" type="node,way" preset_name_label="true">

resources/styles/standard/elemstyles.mapcss

@@ -1034 +1034 @@
     icon-image: "presets/vehicle/passing_place.svg";
     set icon_z17;
 }
+way > node[highway=passing_place][passing_place=left] {
+    icon-image: "presets/vehicle/passing_place.svg";
+    icon-rotation: parent_way_angle() + 90deg;
+}
+way > node[highway=passing_place][passing_place=right] {
+    icon-image: "presets/vehicle/passing_place.svg";
+    icon-rotation: parent_way_angle() - 90deg;
+}
 node[highway=emergency_bay] {
     icon-image: "presets/vehicle/emergency_bay.svg";
     set icon_z17;

The issue is with the rotation: it is not always propagating on the map after changes (let alone on setting the passing_place=* key). I think it’s due to icon caching, but haven't had the time to figure out, yet.

It affects every dynamic icon preset as I've seen it so far.

(I got the idea from Styles/orientation for traffic signs mappaint style.)

[gaben]

I know, the passing_place=both is not handled :)

It probably needs a new icon.