id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
24698	[WIP patch] Add placement info to highway=passing_place preset	gaben	team	"I'd like to add the placement info to the `highway=passing_place` preset.

Unfortunately, the following patch does not work as I want it to:

{{{#!patch
Index: resources/data/defaultpresets.xml
===================================================================
--- resources/data/defaultpresets.xml	(revision 19561)
+++ resources/data/defaultpresets.xml	(working copy)
@@ -1619,6 +1619,9 @@
         <item name=""Passing Place"" icon=""presets/vehicle/passing_place.svg"" type=""node"" preset_name_label=""true"">
             <link wiki=""Tag:highway=passing_place"" />
             <key key=""highway"" value=""passing_place"" />
+            <optional>
+                <combo key=""passing_place"" text=""Placement in way direction"" values=""left,right,both"" values_sort=""false"" />
+            </optional>
             <preset_link preset_name=""Emergency Bay"" text=""Similar but different tags:""/>
         </item> <!-- Passing Place -->
         <item name=""Emergency Bay"" icon=""presets/vehicle/emergency_bay.svg"" type=""node,way"" preset_name_label=""true"">
Index: resources/styles/standard/elemstyles.mapcss
===================================================================
--- resources/styles/standard/elemstyles.mapcss	(revision 19561)
+++ resources/styles/standard/elemstyles.mapcss	(working copy)
@@ -1034,6 +1034,14 @@
     icon-image: ""presets/vehicle/passing_place.svg"";
     set icon_z17;
 }
+way > node[highway=passing_place][passing_place=left] {
+    icon-image: ""presets/vehicle/passing_place.svg"";
+    icon-rotation: parent_way_angle() + 90deg;
+}
+way > node[highway=passing_place][passing_place=right] {
+    icon-image: ""presets/vehicle/passing_place.svg"";
+    icon-rotation: parent_way_angle() - 90deg;
+}
 node[highway=emergency_bay] {
     icon-image: ""presets/vehicle/emergency_bay.svg"";
     set icon_z17;
}}}

The issue is with the rotation: it is not always propagating on the map after changes (let alone on setting the `passing_place=*` key). I think it’s due to icon caching, but haven't had the time to figure out, ''yet''.

It affects every dynamic icon preset as I've seen it so far.

(I got the idea from `Styles/orientation for traffic signs` mappaint style.)"	enhancement	new	normal		Internal preset			passing_place rotation