Fix new PMD warnings

[stoecker]

After PMD upgrade a bunch of new warnings cam up.

Anyone time to help fixing them?

[gaben]

Anyone time..?

I don't have any at the moment, but hopefully I will have some in the following weeks.

[GerdP]

Sorry, the recent changes caused another build failure in my Eclipse installation, so atm I try to fix that.

[stoecker]

I found that an "svn cleanup --remove-ignored" helped. I had to do this for the CI to work.

[stoecker]

Also note, that while I tried to keep downwards compatibility intact I may have created some places where Java >= 21 is required. I don't plan to actively search such issues as long as the JOSM server stuff for the needed builds does still work with Java 11.

[GerdP]

My problems with Eclipse are fixed. No idea what exactly was wrong, it used an older version of the compression library.

[GerdP]

Where do I see the bunch of PMD warnings?

[GerdP]

Ah, didn't use svn update today. Now I see when running ant pmd

[stoecker]

Replying to GerdP:

My problems with Eclipse are fixed. No idea what exactly was wrong

That's the reason why I don't use eclipse. That "No idea why" happened too often to me...

[GerdP]

I can take care about the "Public member ... declared in a non-public type" messages. My understanding is that I just have to remove the public key word.

[stoecker]

Replying to GerdP:

I can take care about the "Public member ... declared in a non-public type" messages. My understanding is that I just have to remove the public key word.

Or change to "protected"? I'm not totally sure. Had only a short look at the PMD description.

[GerdP]

In ​https://github.com/pmd/pmd/pull/6231 I see that either public should be removed or private should be added.
Anyhow there seem to be more to this because when I change the flagged places in src\org\openstreetmap\josm\data\coor\Coordinate.java I can no longer compile. Not yet sure if this is a PMD error or if I have to change more code.

[stoecker]

In 19520/josm:

ignore rule PublicMemberInNonPublicType, see #24635

[stoecker]

In 19535/josm:

remove a lot of PMD warnings, especially outdated ignores, see #24635

[stoecker]

In 19536/josm:

remove PMD ImplicitFunctionalInterface, see #24635

[stoecker]

In 19537/josm:

fix one more PMD, see #24635

[stoecker]

In 19538/josm:

fix one more PMD, see #24635, drop java.util.Date in SyncEditorLayerIndex

[stoecker]

Only 2 types missing:

• ReplaceJavaUtilDate
• OverrideBothEqualsAndHashCodeOnComparable

[stoecker]

In 19539/josm:

see #24635 - remove usage of Date

[stoecker]

In 19541/josm:

remove outdated expiry data check, see #24635