Changeset 19628 in josm


Ignore:
Timestamp:
2026-10-01T17:41:55+02:00 (2 days ago)
Author:
gaben
Message:

see #24635 - update PMD to 7.28.0 and re-enable several rules, remove deprecated and not reporting ones

Location:
trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/nodist/pom.xml

    r19621 r19628  
    1818        <sonar.projectKey>JOSM</sonar.projectKey>
    1919        <jmockit.version>1.49.a</jmockit.version>
    20         <pmd.version>7.22.0</pmd.version>
     20        <pmd.version>7.28.0</pmd.version>
    2121        <jacoco.version>0.8.13</jacoco.version>
    2222        <checkstyle.version>10.26.1</checkstyle.version>

  • trunk/tools/ivy.xml

    r19543 r19628  
    2121        <dependency org="com.guardsquare" name="proguard-ant" rev="7.8.2" conf="proguard->default"/>
    2222        <!-- pmd->default -->
    23         <dependency org="net.sourceforge.pmd" name="pmd-core" rev="7.22.0" conf="pmd->default"/>
    24         <dependency org="net.sourceforge.pmd" name="pmd-ant" rev="7.22.0" conf="pmd->default"/>
    25         <dependency org="net.sourceforge.pmd" name="pmd-java" rev="7.22.0" conf="pmd->default"/>
     23        <dependency org="net.sourceforge.pmd" name="pmd-core" rev="7.28.0" conf="pmd->default"/>
     24        <dependency org="net.sourceforge.pmd" name="pmd-ant" rev="7.28.0" conf="pmd->default"/>
     25        <dependency org="net.sourceforge.pmd" name="pmd-java" rev="7.28.0" conf="pmd->default"/>
    2626        <dependency org="org.xmlresolver" name="xmlresolver" rev="6.0.21" conf="pmd->default"/>
    2727        <!-- spotbugs->default -->

  • trunk/tools/pmd/josm-ruleset.xml

    r19535 r19628  
    1717    <exclude name="ConstantsInInterface"/>
    1818    <exclude name="GuardLogStatement"/>
    19     <exclude name="JUnit4TestShouldUseTestAnnotation" reason="False positive in src/org/openstreetmap/josm/data/validation/Test.java"/>
    2019    <exclude name="LiteralsFirstInComparisons" reason="Introduced in 6.24, some positives in source code at this time. Replaces PositionLiteralsFirstInComparisons."/>
    2120    <exclude name="LooseCoupling"/>
    … …  
    2322    <exclude name="OneDeclarationPerLine"/>
    2423    <exclude name="ReplaceHashtableWithMap"/>
    25     <exclude name="SwitchStmtsShouldHaveDefault"/>
    2624    <exclude name="SystemPrintln"/>
    2725    <exclude name="UnusedAssignment" reason="Introduced in 6.26, some number of positives in source code at this time"/>
    28     <exclude name="UnusedPrivateMethod" reason="Broken since PMD 6.33, see https://github.com/pmd/pmd/issues/3468"/>
    29     <exclude name="UnusedPrivateField" reason="Broken in 7.2.x"/>
    3026    <exclude name="UseVarargs"/>
    3127  </rule>
    … …  
    5955    <exclude name="MethodArgumentCouldBeFinal"/>
    6056    <exclude name="MethodNamingConventions"/>
    61     <exclude name="NoPackage"/>
    6257    <exclude name="OnlyOneReturn"/>
    6358    <exclude name="PrematureDeclaration"/>
    … …  
    130125    <exclude name="SimplifiedTernary"/>
    131126    <exclude name="SimplifyBooleanReturns" reason="Increased sensitivity in 7.x; should be fixed in our source code." />
    132     <exclude name="SimplifyConditional"/>
    133127    <exclude name="SingularField"/>
    134128    <exclude name="SwitchDensity"/>
    135129    <exclude name="TooManyFields"/>
    136130    <exclude name="TooManyMethods"/>
    137     <exclude name="UseObjectForClearerAPI"/>
    138131    <exclude name="UselessOverridingMethod"/>
    139     <exclude name="UseUtilityClass"/>
    140132  </rule>
    141133  <rule ref="category/java/design.xml/SignatureDeclareThrowsException">
    … …  
    150142    <exclude name="AssignmentToNonFinalStatic"/>
    151143    <exclude name="AvoidBranchingStatementAsLastInLoop"/>
    152     <exclude name="AvoidCatchingNPE"/>
    153144    <exclude name="AvoidDuplicateLiterals"/>
    154145    <exclude name="AvoidFieldNameMatchingMethodName"/>
    … …  
    160151    <exclude name="ConstructorCallsOverridableMethod"/>
    161152    <exclude name="DoNotTerminateVM"/>
    162     <exclude name="DontImportSun"/>
    163153    <exclude name="ImplicitSwitchFallThrough"/>
    164154    <exclude name="MissingSerialVersionUID"/>
    … …  
    182172    <exclude name="AvoidInstantiatingObjectsInLoops"/>
    183173    <exclude name="ConsecutiveLiteralAppends"/>
    184     <exclude name="InefficientEmptyStringCheck"/>
    185174    <exclude name="InsufficientStringBufferDeclaration" reason="PMD 6.40 has a bug where it doesn't properly count appended strings in if statements."/>
    186     <exclude name="TooFewBranchesForASwitchStatement"/>
    187     <exclude name="UseArrayListInsteadOfVector"/>
    188     <exclude name="UselessStringValueOf"/>
    189175    <exclude name="UseStringBufferForStringAppends"/>
    190176  </rule>
Note: See TracChangeset for help on using the changeset viewer.