Modify

Opened 30 hours ago

#24482 new enhancement

[PATCH] Give autofilters feature parity with manual level filters for indoor mapping

Reported by: tordanik Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

Despite the availability of a level=* autofilter, I see experienced indoor mappers continue to use manually defined filters. This is because the autofilters do not yet have feature parity with manual filters:

  • Manual filters can either disable or hide elements. Autofilters can only disable elements.
  • Manual filters can consider more than one key. With indoor mapping, this is relevant for repeat_on.
  • You can use more than one manual filter at the same time, e.g. if you want to draw steps between level 3 and level 4 and therefore need to see features from both levels.
  • Manual filters let you find elements without the relevant key.

There are also a few other inconvenient behaviors:

  • As soon as level ranges (such as level=3-6) are used, the autofilter buttons for level=* show fractional levels (such as 3.5) even though they're not actually used in the building. (Since they were added in #...)
  • The list of buttons is not reliably updated when a tag with a relevant key is added or the last element with the relevant tag is deleted.
  • Buttons are not always large enough to show the value, especially on systems with UI scaling.

I'm providing patches to fix all of these:

  • Support repeat_on in level autofilter (autofilter_01_repeat_on)
  • Allow hiding auto-filtered elements (autofilter_02_hiding)
  • Only show fractional autofilter values if they are explicitly used (autofilter_03_fractional)
  • Allow more than one autofilter value to be selected at the same time (autofilter_04_multi)
  • Add an autofilter for missing level value (autofilter_05_none)
  • Get autofilter button size after adding it for more accurate values (autofilter_06_button_size)
  • Update the autofilter buttons after tag changes and element deletions (autofilter_07_update)

The patches are best applied in the order listed.

Attachments (8)

autofilter_01_repeat_on.patch (6.4 KB ) - added by tordanik 30 hours ago.
autofilter_02_hiding.patch (6.1 KB ) - added by tordanik 30 hours ago.
autofilter_03_fractional.patch (6.7 KB ) - added by tordanik 30 hours ago.
autofilter_04_multi.patch (13.8 KB ) - added by tordanik 30 hours ago.
autofilter_05_none.patch (8.2 KB ) - added by tordanik 30 hours ago.
autofilter_06_button_size.patch (909 bytes ) - added by tordanik 30 hours ago.
autofilter_07_update.patch (1.3 KB ) - added by tordanik 30 hours ago.
autofilter_all.patch (33.3 KB ) - added by tordanik 30 hours ago.

Download all attachments as: .zip

Change History (8)

by tordanik, 30 hours ago

by tordanik, 30 hours ago

Attachment: autofilter_02_hiding.patch added

by tordanik, 30 hours ago

by tordanik, 30 hours ago

Attachment: autofilter_04_multi.patch added

by tordanik, 30 hours ago

Attachment: autofilter_05_none.patch added

by tordanik, 30 hours ago

by tordanik, 30 hours ago

Attachment: autofilter_07_update.patch added

by tordanik, 30 hours ago

Attachment: autofilter_all.patch added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to tordanik.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.