Modify

Opened 8 weeks ago

Closed 8 weeks ago

#24449 closed defect (invalid)

"Missing tag" validator doesn't take into account "disused" prefix

Reported by: GuardedBear Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description

When validating data, warnings are raised if there's a missing tag (e.g. "sport without physical feature"), however this doesn't take into account the "disused:" prefix.

For example, a sports pitch tagged:

disused:leisure=pitch
sport=tennis

is flagged with this warning. But I don't think adding disused:sport=tennis is the answer.

So I believe this validation should take into account features with a "disused:" prefix, and ignore them.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-07-11 10:12:51 +0200 (Fri, 11 Jul 2025)
Revision:19423
Build-Date:2025-07-12 01:30:35
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19423 en_AU)
Java version: 21.0.8
Java package: openjdk-21-jre:amd64-21.0.8
libcommons-logging-java: libcommons-logging-java:all-1.3.0
fonts-noto: fonts-noto:all-20201225-2
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, -XX:MaxRAMPercentage=75.0, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Attachments (1)

2025-08-26_09-35.png (304.3 KB ) - added by GuardedBear 8 weeks ago.

Download all attachments as: .zip

Change History (3)

by GuardedBear, 8 weeks ago

Attachment: 2025-08-26_09-35.png added

comment:1 by stoecker, 8 weeks ago

But I don't think adding disused:sport=tennis is the answer.

Actually I would think exactly that is the right way to go.

comment:2 by GuardedBear, 8 weeks ago

Resolution: invalid
Status: newclosed

Hmm, I thought you just prefixed the main tag with 'disused' and left the rest as-is... But now that I read https://wiki.openstreetmap.org/wiki/Key:disused:* properly I can see that adding 'disused' to the 'sport' tag as well does make sense.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.