Opened 5 weeks ago
Closed 26 hours ago
#24347 closed enhancement (fixed)
[PATCH] Add gps time choice on image/gpx correlation
| Reported by: | StephaneP | Owned by: | StephaneP |
|---|---|---|---|
| Priority: | normal | Milestone: | 25.07 |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Hi!
When you correlate image with a gnss track to geolocalize these images, Josm always use the Exif DateTimeOriginal timestamp value.
This patch add a choice to use the Exif GPS DateTime value.
It's helpful because you don't have to set the correct Timezone (it is 0:00) and the time offset is usually near 0.
But beware of the camera behavior when you've lost the GNSS signal (tunnel, indoor).
new GUI choice screenshot :
Attachments (4)
Change History (13)
by , 5 weeks ago
| Attachment: | ticket_24347.patch added |
|---|
by , 5 weeks ago
| Attachment: | Josm_gpx_correlation_time_source_choice.jpg added |
|---|
comment:1 by , 5 weeks ago
| Description: | modified (diff) |
|---|
follow-up: 3 comment:2 by , 5 weeks ago
comment:3 by , 5 weeks ago
Ok
What about getSelectedInstant(), or a bit long too, getTimeSourceInstant()?
by , 5 weeks ago
| Attachment: | ticket_24347_B.patch added |
|---|
patch with getThisInstant() renamed to getTimeSourceInstant()
comment:5 by , 5 weeks ago
| Milestone: | → 25.06 |
|---|
comment:6 by , 3 days ago
| Milestone: | 25.06 → 25.07 |
|---|
comment:7 by , 30 hours ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
Well, I forgot to handle that last month, but now I tried and it's missing the file TimeSource.java. Please add it.
by , 29 hours ago
| Attachment: | ticket_24347_C.patch added |
|---|
comment:8 by , 29 hours ago
Oh! Sorry! I was fooled with this untracked file by git. The ticket_24347_C.patch file include the missing file.
On first look: Please not getThisInstant(). That's a strange name. getInstantBySource() would be better, but a bit long. Maybe you find something more suitable.