[Patch] Search dialog should not offer some options when nothing is selected and a selection is needed

[GerdP]

What steps will reproduce the problem?

1. Have a large number of objects selected
2. Open search dialog
3. Select e.g. option "remove from selection" and search for something
4. work on...
5. Make sure nothing is selected
6. Use search again and search something special, not thinking about the previously selected option

What is the expected result?

JOSM disables the options "remove from selection" and "find in selecion" when nothing is selected

What happens instead?

JOSM remembers the selected option and shows a popup "Nothing removed from selection". If you don't expect to find something it is likely that you don't look at the exact message text and just recognize that nothing was found.

Please provide any additional information below. Attach a screenshot if possible.

I'v made this error several times and only noticed it when I was sure that the searh should find something.
An alternative solution might be to disable the "Search" (OK) button if a selection is needed?

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-05-01 13:38:02 +0200 (Thu, 01 May 2025)
Revision:19396
Build-Date:2025-05-02 01:30:34
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19396 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 1888 MB / 1888 MB (825 MB allocated, but free)
Java version: 21.0.2+13-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19039, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36438)
+ apache-commons (36438)
+ buildings_tools (36438)
+ comfort0 (36438)
+ ejml (36438)
+ geotools (36438)
+ jackson (36438)
+ jaxb (36438)
+ jts (36438)
+ o5m (36438)
+ opendata (36440)
+ pbf (36438)
+ photo_geotagging (36438)
+ poly (36438)
+ reltoolbox (36438)
+ reverter (36447)
+ terracer (36438)
+ undelete (36438)
+ utilsplugin2 (36438)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Map paint styles:
+ c:\josm\core\resources\styles\standard\elemstyles.mapcss

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 00045.841 W: java.io.IOException: Attribution is not loaded yet
- 00045.841 W: java.io.IOException: Attribution is not loaded yet
- 00045.842 W: java.io.IOException: Attribution is not loaded yet
- 00045.843 W: java.io.IOException: Attribution is not loaded yet
- 00045.843 W: java.io.IOException: Attribution is not loaded yet
- 00045.844 W: java.io.IOException: Attribution is not loaded yet
- 00045.844 W: java.io.IOException: Attribution is not loaded yet
- 00045.845 W: java.io.IOException: Attribution is not loaded yet
- 00045.846 W: java.io.IOException: Attribution is not loaded yet
- 00045.847 W: java.io.IOException: Attribution is not loaded yet

[GerdP]

disable radio buttons with need a selection, set mode to replace if search dialog is opened with empty collection (but not when a Filter is created)

[GerdP]

In 19414/josm:

fix #24333: Search dialog should not offer some options when nothing is selected and a selection is needed

• disable radio buttons which need a selection, set mode to replace if search dialog is opened with empty collection (but not when a Filter is created)