[Patch] Upload Selection action not enabled after update

[GerdP]

What steps will reproduce the problem?

1. Start JOSM, download some data from OSM, possibly modify lots of things
2. Select an object, e.g. a node, note that it is wrongly tagged
3. add or delete a tag
4. try to use "Upload selection..." the just changed object

What is the expected result?

Action "Upload selection..." is enabled because the selection was updated

What happens instead?

Action is disabled, I have to change the selection and select the object again to enable it.

Please provide any additional information below. Attach a screenshot if possible.

I hit this problem while checking hundreds of information=guidepost nodes when I want to fix the specific problem (e.g. missing direction=*) in a separate changeset before purging the node (because it was checked).

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-05-01 13:38:02 +0200 (Thu, 01 May 2025)
Revision:19396
Build-Date:2025-05-02 01:30:34
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19396 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 1888 MB / 1888 MB (257 MB allocated, but free)
Java version: 21.0.2+13-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19039, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM HWConsole.exe]

Dataset consistency test:
[NO DATASET] {Relation id=19024489 version=2 VT [node 10777923075, node 10777923074, node 10777923073, node 10223065698, way 777540325]} is referenced by {Relation id=4613741 version=342 MVT [relation 19022368, relation 19024486, relation 19024487, relation 19024485, relation 19022186, relation 19024490, relation 19022187, relation 19024491, relation 19024488, relation 19024489, relation 19024494, relation 19024495, relation 19024492, relation 19024493, relation 19024498, relation 19024496, relation 19024497, relation 19024542, relation 19022362, relation 19022363, relation 19022366, relation 19022367, relation 19024541, relation 19022365, relation 19024540, relation 19024594, relation 19024593, relation 19024591, relation 19024592, relation 19024590, relation 19024687, relation 19024699, relation 19024704, relation 19024783, relation 19024792, relation 19024833, relation 19024851, relation 19024849, relation 19024878, relation 19024877, relation 19024912, relation 19024950, relation 19024963, relation 19025370, relation 19025509, relation 19022189, relation 19025507, relation 19025506, relation 19025505, relation 19025578, relation 19025577, relation 19025673, relation 19025674, relation 19025861, relation 19025860, relation 19025859, relation 19025858, relation 19025857, relation 19025856, relation 19025855, relation 19025918, relation 19025917, relation 19028196, relation 19028195, relation 19031459, relation 19028194, relation 19031356, relation 19031458, relation 19031457, relation 19031456, relation 19031455, relation 19031454, relation 19032115, relation 19032114, relation 19032113, relation 19032112, relation 19032111, relation 19032110, relation 19032109, relation 19032108, relation 19032107, relation 19032106, relation 19032105, relation 19032104, relation 19032103, relation 19032102, relation 19032101, relation 19032100, relation 19032099, relation 19032098, relation 19032097, relation 19032096, relation 19032095, relation 19032094, relation 19032093, relation 19032092, relation 19032091, relation 19032090, relation 19032089, relation 19035673, relation 19035671, relation 19035664, relation 19035669, relation 19035668, relation 19035674, relation 19035672, relation 19035667, relation 19035670, relation 19035666, relation 19035663, relation 19035665, relation 19035654, relation 19035662, relation 19035658, relation 19035653, relation 19035652, relation 19035657, relation 19035661, relation 19035649, relation 19035656, relation 19035648, relation 19035651, relation 19035660, relation 19035655, relation 19035659, relation 19035650, relation 19036194, relation 19036196, relation 19036193, relation 19036195, relation 19036215, relation 19036648, relation 19036647, relation 19036654, relation 19036650, relation 19036649, relation 19036652, relation 19036653, relation 19036645, relation 19036646, relation 19036651, relation 19022188, relation 19036644, relation 19036641, relation 19036643, relation 19036642, relation 19036639, relation 19036640, relation 19039998, relation 19040002, relation 19040004, relation 19039994, relation 19039997, relation 19040011, relation 19040010, relation 19040012, relation 19040007, relation 19040001, relation 19039996, relation 19040009, relation 19039999, relation 19040006, relation 19040003, relation 19040000, relation 19039995, relation 19040005, relation 19040008, relation 19045495, relation 19022364, relation 19045659, relation 19045841, relation 19045842, relation 19045840, relation 19046008, relation 19046009, relation 19046010, relation 19046802, relation 19046803, relation 19046804, relation 19051950, relation 19053048, relation 19057281, relation 19057282, relation 19053689, relation 19057283, relation 19062201, relation 19062198, relation 19062450, relation 19062199, relation 19062200, relation 19063562, relation 19063563, relation 19063561, relation 19063560, relation 19063559, relation 14282886, relation 19063696, relation 19069440, relation 19069439, relation 19069441, relation 19069438, relation 19073200, relation 19080455, relation 19080454, relation 19080453, relation 19081318, relation 19084330, relation 19084331, relation 19091670, relation 19091669, relation 19092878, relation 19092877, relation 19092896, relation 19092976, relation 19092975, relation 19092974, relation 19096410, relation 19093021, relation 19160758, relation 19161230, relation 19161229, relation 19161228, relation 19161227, relation 19161687, relation 19162042, relation 19162041, relation 19164271, relation 19164272, relation 19169383, relation 19169381, relation 19169380, relation 19169382, relation 19169379, relation 19069842, relation 19069843, relation 19069844, relation 19171204, relation 19069845, relation 19171203, relation 19171205, relation 19171206, relation 19172207, relation 19172205, relation 19172208, relation 19172206, relation 19173287, relation 19173291, relation 19173288, relation 19173290, relation 19173289, relation 19173286, relation 19173285]} but not found in dataset
[NO DATASET] {Relation id=19040009 version=1 VT [node 10771330921, node 10771330922, way 257807100, way 257807099, way 33432489, way 1381313422]} is referenced by {Relation id=4613741 version=342 MVT [relation 19022368, relation 19024486, relation 19024487, relation 19024485, relation 19022186, relation 19024490, relation 19022187, relation 19024491, relation 19024488, relation 19024489, relation 19024494, relation 19024495, relation 19024492, relation 19024493, relation 19024498, relation 19024496, relation 19024497, relation 19024542, relation 19022362, relation 19022363, relation 19022366, relation 19022367, relation 19024541, relation 19022365, relation 19024540, relation 19024594, relation 19024593, relation 19024591, relation 19024592, relation 19024590, relation 19024687, relation 19024699, relation 19024704, relation 19024783, relation 19024792, relation 19024833, relation 19024851, relation 19024849, relation 19024878, relation 19024877, relation 19024912, relation 19024950, relation 19024963, relation 19025370, relation 19025509, relation 19022189, relation 19025507, relation 19025506, relation 19025505, relation 19025578, relation 19025577, relation 19025673, relation 19025674, relation 19025861, relation 19025860, relation 19025859, relation 19025858, relation 19025857, relation 19025856, relation 19025855, relation 19025918, relation 19025917, relation 19028196, relation 19028195, relation 19031459, relation 19028194, relation 19031356, relation 19031458, relation 19031457, relation 19031456, relation 19031455, relation 19031454, relation 19032115, relation 19032114, relation 19032113, relation 19032112, relation 19032111, relation 19032110, relation 19032109, relation 19032108, relation 19032107, relation 19032106, relation 19032105, relation 19032104, relation 19032103, relation 19032102, relation 19032101, relation 19032100, relation 19032099, relation 19032098, relation 19032097, relation 19032096, relation 19032095, relation 19032094, relation 19032093, relation 19032092, relation 19032091, relation 19032090, relation 19032089, relation 19035673, relation 19035671, relation 19035664, relation 19035669, relation 19035668, relation 19035674, relation 19035672, relation 19035667, relation 19035670, relation 19035666, relation 19035663, relation 19035665, relation 19035654, relation 19035662, relation 19035658, relation 19035653, relation 19035652, relation 19035657, relation 19035661, relation 19035649, relation 19035656, relation 19035648, relation 19035651, relation 19035660, relation 19035655, relation 19035659, relation 19035650, relation 19036194, relation 19036196, relation 19036193, relation 19036195, relation 19036215, relation 19036648, relation 19036647, relation 19036654, relation 19036650, relation 19036649, relation 19036652, relation 19036653, relation 19036645, relation 19036646, relation 19036651, relation 19022188, relation 19036644, relation 19036641, relation 19036643, relation 19036642, relation 19036639, relation 19036640, relation 19039998, relation 19040002, relation 19040004, relation 19039994, relation 19039997, relation 19040011, relation 19040010, relation 19040012, relation 19040007, relation 19040001, relation 19039996, relation 19040009, relation 19039999, relation 19040006, relation 19040003, relation 19040000, relation 19039995, relation 19040005, relation 19040008, relation 19045495, relation 19022364, relation 19045659, relation 19045841, relation 19045842, relation 19045840, relation 19046008, relation 19046009, relation 19046010, relation 19046802, relation 19046803, relation 19046804, relation 19051950, relation 19053048, relation 19057281, relation 19057282, relation 19053689, relation 19057283, relation 19062201, relation 19062198, relation 19062450, relation 19062199, relation 19062200, relation 19063562, relation 19063563, relation 19063561, relation 19063560, relation 19063559, relation 14282886, relation 19063696, relation 19069440, relation 19069439, relation 19069441, relation 19069438, relation 19073200, relation 19080455, relation 19080454, relation 19080453, relation 19081318, relation 19084330, relation 19084331, relation 19091670, relation 19091669, relation 19092878, relation 19092877, relation 19092896, relation 19092976, relation 19092975, relation 19092974, relation 19096410, relation 19093021, relation 19160758, relation 19161230, relation 19161229, relation 19161228, relation 19161227, relation 19161687, relation 19162042, relation 19162041, relation 19164271, relation 19164272, relation 19169383, relation 19169381, relation 19169380, relation 19169382, relation 19169379, relation 19069842, relation 19069843, relation 19069844, relation 19171204, relation 19069845, relation 19171203, relation 19171205, relation 19171206, relation 19172207, relation 19172205, relation 19172208, relation 19172206, relation 19173287, relation 19173291, relation 19173288, relation 19173290, relation 19173289, relation 19173286, relation 19173285]} but not found in dataset


Plugins:
+ OpeningHoursEditor (36438)
+ apache-commons (36438)
+ buildings_tools (36438)
+ comfort0 (36438)
+ ejml (36438)
+ geotools (36438)
+ jackson (36438)
+ jaxb (36438)
+ jts (36438)
+ o5m (36438)
+ opendata (36440)
+ pbf (36438)
+ photo_geotagging (36438)
+ poly (36438)
+ reltoolbox (36438)
+ reverter (36447)
+ terracer (36438)
+ undelete (36438)
+ utilsplugin2 (36438)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Map paint styles:
+ c:\josm\core\resources\styles\standard\elemstyles.mapcss

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 01863.263 W: java.io.IOException: Attribution is not loaded yet
- 01863.263 W: java.io.IOException: Attribution is not loaded yet
- 01863.263 W: java.io.IOException: Attribution is not loaded yet
- 01863.264 W: java.io.IOException: Attribution is not loaded yet
- 01863.264 W: java.io.IOException: Attribution is not loaded yet
- 03680.917 W: org.openstreetmap.josm.tools.bugreport.BugReportSender$BugReportSenderException: java.io.IOException: stream is closed. Cause: java.io.IOException: stream is closed
- 03717.088 W: org.openstreetmap.josm.tools.bugreport.BugReportSender$BugReportSenderException: java.io.IOException: stream is closed. Cause: java.io.IOException: stream is closed
- 05177.634 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 05178.541 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 05517.029 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Relation member must be part of the same dataset as relation(relation 4613741, relation 19024486) (changed by the following commands: )

[GerdP]

Just noticed that this problem only occurs when there is at least one changed element and then another elemet is selected.

[GerdP]

Add listener

[GerdP]

Please review. I always feel uncertain when it comes to listeners.

[stoecker]

Don't see anything obviously wrong...

[GerdP]

In 19410/josm:

fix #24329:Upload Selection action not enabled after update

• add listener so that the action is enabled after the selected object was changed