Modify ↓

Opened 8 months ago

#24073 new defect

Treat the tag waterway=fish_pass like waterway=stream

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

As of now, the tag is (only) used 2811 times, but it is described in the wiki:
​https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dfish_pass

The current code in JOSM #r19277 already contains one validation test that treats waterway=fish_pass, but it is missing in some other tests and in the presets and the default style.

The attached patch fixes all but the default style. I guess an icon should display the typical geometry of a bypass, but I have two left hands when it comes to painting.

The rendering is just an approach. I'd prefer to have something that suggests white water.
Any help with the rendering and presets is welcomed.

Attachments (1)

20473.patch​ (4.6 KB ) - added by GerdP 8 months ago.
tests and simple rendering

Download all attachments as: .zip

Change History (1)

by GerdP, 8 months ago

Attachment: 20473.patch​ added

tests and simple rendering

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to GerdP.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.