Modify

Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#24066 closed defect (fixed)

Cannot update my preset zip file

Reported by: severin.menard Owned by: team
Priority: normal Milestone:
Component: External preset Version:
Keywords: DisasterDamageAssessment Cc: stoecker

Description

I am trying to update the zip file of the presets I have recently created, but I get this error message. I have tried to log out/log in again but it remains the same.

https://josm.openstreetmap.de/attachment/wiki/Presets/DisasterDamageAssessment

Error: Forbidden

You don't have permission to replace the attachment DisasterDamageAssessment.zip. You can only replace your own attachments. Replacing other's attachments requires ATTACHMENT_DELETE permission.

Attachments (1)

DisasterDamageAssessment.zip (7.7 KB ) - added by severin.menard 12 months ago.

Download all attachments as: .zip

Change History (12)

by severin.menard, 12 months ago

comment:1 by severin.menard, 12 months ago

Ah OK, I got it, @stoecker edited my upload and now only his version shows up with the mention "Icons only". I tried to follow the https://josm.openstreetmap.de/wiki/Styles#Iconhandling guidelines and include the mapcss in the zip file as well. What should I do? The icons are currently not displayed in JOSM.

comment:2 by skyper, 12 months ago

Cc: stoecker added
Component: CoreExternal preset
Keywords: DisasterDamageAssessment added

Yes, attachment can only be changed by the user.

You should not attach the xml. The server takes the code from the wiki page and creates the mapcss (xml) automatically. Additionally all other attachments are included in the automatically created zip file which can lead to unneeded bigger file sizes if you do not follow the rules.

Dirk (@stoecker) already tried to fix it, but unfortunately he also made a mistake as in order to include icons from a zip file you need to add a keyword (EXTRACED) in the upload comment. A similar keyword (NOZIP) exist to exclude attachment. See the second to last item at Icon handling.

To fix the current situation, you can attach the icons as zip file again under a different name but do not forget to add (EXTRACED) in the comment. As a common user cannot delete any attached file, the option to get the maintainers attention is to mark the attachment as "spam" (link at the right side in the lowest line of the header) and leave a useful comment. Though, I guess we have Dirk's attention already in this case.

Edit: Sorry, I got the keywords totally wrong. Fixed now.

Last edited 12 months ago by skyper (previous) (diff)

comment:3 by skyper, 12 months ago

Sorry, I got the keywords totally wrong. Fixed now.

comment:4 by stoecker, 12 months ago

Resolution: fixed
Status: newclosed

Ooops. Sorry. Forgot the EXTRACT text.

I added EXTRACT (no ED at the end :-) now and made you the owner again, so you can upload future changes again.

P.S. When only a few icons I recommend adding icons directly. Makes future updates easier (although it's also possible to mix individual files and ZIP files, for the server it doesn't matter where the stuff comes from...). Only rule is that only additional files like icons are in the attachment and the main style/rule/presets is in the wiki page, otherwise using a wiki makes no sense (which is also possible, using external stuff only linked here - but we prefer the wiki ).

comment:5 by severin.menard, 12 months ago

Thanks for the explanation! To summarize: upload a zip file with only the icons and add EXTRACT in the comment, right? Any requirement for the zip file name?
But on my side, the problem still seems to be there: no icons are displayed for this preset, but also for the style with the same name.

in reply to:  5 ; comment:6 by stoecker, 12 months ago

Replying to severin.menard:

Thanks for the explanation! To summarize: upload a zip file with only the icons and add EXTRACT in the comment, right? Any requirement for the zip file name?

(EXTRACT), the brackets are part of the keyword. No other conditions, the file name is irrelevant, but I suggest to keep the zip extension :-)

But on my side, the problem still seems to be there: no icons are displayed for this preset, but also for the style with the same name.

Probably a caching issue. Removing and later readding the preset/style should help. There probably also is a refresh option somewhere, but I don't remember if this is the case.

in reply to:  6 comment:7 by skyper, 12 months ago

Replying to stoecker:

Probably a caching issue. Removing and later readding the preset/style should help. There probably also is a refresh option somewhere, but I don't remember if this is the case.

See wiki:Presets#UpdatingAvailablepresetsinJOSM and wiki:Styles#UpdatingstylesinJOSM

comment:8 by severin.menard, 12 months ago

Thanks for the tip, it worked fine, except for the icon: "matrix-icons.png" that should appeared in both the presets and styles contributor list in JOSM.

I cannot see a difference about this with https://josm.openstreetmap.de/wiki/Styles/BAR-damage-assessment that uses the same icon but works fine, except that the zip file there contains both the icons and the mapcss file. Would this be the fix?

comment:9 by stoecker, 12 months ago

Something is wrong, but I don't know yet what...

Probably something totally simple.

I cannot see a difference about this with https://josm.openstreetmap.de/wiki/Styles/BAR-damage-assessment that uses the same icon but works fine, except that the zip file there contains both the icons and the mapcss file. Would this be the fix?

I removed the wrong secondary file there.

comment:10 by stoecker, 12 months ago

Ah, guess what? Caching issue on the server side ;-)

In case of a download error for the image it needs some time to retry to not overload remote servers. And because the images haven't been handled properly in the beginning...

comment:11 by stoecker, 12 months ago

P.S. Your last Maps/France change: When you add an new entry with {apikey} you need to ping me (mail or ticket), so I can add it. ATM that's handled individually for each entry and not server specific.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.