Opened 11 months ago

Last modified 9 months ago

#23945 closed enhancement

[PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed — at Version 4

Reported by: IreuN Owned by: team
Priority: normal Milestone: 24.12
Component: Core image mapping Version:
Keywords: Cc:

Description (last modified by gaben)

Hello!

I'm asking you if mention method could be changed to not zoom map to the image, in case the image is the same one.
This could be benefitial to Mapillary plugin, which has to re-display the image after sequence has been downloaded (without it, the previous/next buttons are disabled.

as i can see there is already imageChanged = currentEntry != entry; which could be fed to the if statement.

            imageChanged = currentEntry != entry;

            if (centerView && entry != null && MainApplication.isDisplayingMapView() && entry.getPos() != null) {
                MainApplication.getMap().mapView.zoomTo(entry.getPos());
            }

josm/trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java#L893​

Change History (5)

comment:1 by IreuN, 11 months ago

Video of what this causes: ​https://streamable.com/osypzs

comment:3 by IreuN, 11 months ago

Summary: ImageViewerDialog.displayImages() - do not re-center if the image has not changed → [PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed

by IreuN, 11 months ago

Attachment: 78e599ef8d48e96abbec01c697e6987f8dc4d7e5.patch​ added

comment:4 by gaben, 11 months ago

Component: Core → Core image mapping
Description: modified (diff)
Note: See TracTickets for help on using tickets.