Opened 16 years ago
Closed 13 years ago
#2387 closed defect (fixed)
oneway=no shown with arrow
Reported by: | smsm1 | Owned by: | ulfl |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Internal mappaint style | Version: | |
Keywords: | Cc: | unriccio@…, kay_D, nakor.wp@… |
Description
It seems that oneway=no is shown as though it is a one way road, which isn't true and can be confusing when editing.
Attachments (2)
Change History (15)
comment:1 by , 16 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
comment:2 by , 15 years ago
Cc: | added |
---|---|
Resolution: | wontfix |
Status: | closed → reopened |
that's wrong because all "_link" ways imply oneway=yes, and one have to explicitly tag the oneway=no ways:
http://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway_link
comment:3 by , 15 years ago
JOSM only cares for the key itself and not its value for speed reasons.
Also there is oneway=-1, that reverses direction and that makes such oneways to be shown in the wrong direction in JOSM.
comment:4 by , 15 years ago
Performance is no longer an issue because JOSM now keeps hasDirectionKeys as flag that is recalculated only when primitive keys are changed. It should be even possible (fast enough) to use pattern from Search action to decide whether arrow should be shown
comment:5 by , 15 years ago
Cc: | added |
---|
What happens with the direction of the way, can it still be seen? I use :left and :right a lot and they depend on the direction. If (for oneway=-1) the arrows are reversed visually, I see potential for tagging errors.
comment:7 by , 15 years ago
Cc: | added |
---|
comment:8 by , 15 years ago
Ways with oneway=no no longer have arrows, oneway=-1 is still broken.
What should we do with _link highways? Show arrows unless oneway=no?
Currently the search pattern to identify ways is arrows is as follows: oneway? | incline=* | incline_steep=* | aerialway=* | waterway=stream | waterway=river | waterway=canal | waterway=drain | "piste:type"=downhill | "piste:type"=sled | man_made="piste:halfpipe"
comment:9 by , 15 years ago
follow-up: 12 comment:10 by , 15 years ago
I like to add incline=-10%
(some negative value) to the reversed arrow search pattern. Currently I don't know how. (Maybe regex?)
comment:11 by , 15 years ago
I suggest not showing arrows for “_link” highways at the moment because the implicated tags are unclear. Different languages of the OSM wiki are stating contradictory implications.
The implied tags for “highway=motorway_link” from the wiki:
German: oneway=yes
English: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Italian: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Russian: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Ukrainian: oneway=yes
I am aware of the fact that oneway=yes is given in all cases for highway=motorway_link. However for highway=trunk_link, highway=primary_link or highway=secondary_link this is not implicated in all languages. Instead oneway=* is mentioned.
I suggest, cleaning up the wiki first so that it only implies oneway=yes for all “_link” highways. After that was done, arrows should be shown for “_link” highways unless oneway=no is given.
In my opinion guessing vehicle type restrictions or surfaces should be left to the routers/renders and not be implied globally as implications may differ across regions. Clearly, implying access=no makes no sense but JOSM's bug tracker is not the right place for tagging scheme discussions.
comment:12 by , 15 years ago
Replying to bastiK:
I like to add
incline=-10%
(some negative value) to the reversed arrow search pattern. Currently I don't know how. (Maybe regex?)
I think you can't currently do that. Search expression should get some way to mark that pattern is regular expression or case insensitive, without using checkboxs..
comment:13 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
The main issue of the ticket is fixed (oneway <-> arrows).
The incline problem should go into another ticket.
Note: I think it is dangerous to render oneway and incline with on function. What do you do with a oneway road leading downhill ?
Yes. JOSM only cares for the key itself and not its value for speed reasons. Anyway this is no big issue as oneway=no is default, so it needs not be entered at all.