History: Click on "This changeset has x comments" shows 0 comments in CS-Manager dialog

[GerdP]

What steps will reproduce the problem?

This is a follow up of #23631

1. start JOSM
2. load history for way 37407704
3. click on the button with the tooltip "This changeset has 1 comment"

What is the expected result?

Changeset Manager dialog opens and shows the changeset discussion

What happens instead?

Changeset Manager dialog opens and shows 0 comments. I have to click on the update button to get the wanted result.

Please provide any additional information below. Attach a screenshot if possible.

The dialog

Revision:19056
Is-Local-Build:true
Build-Date:2024-04-25 08:04:26

Identification: JOSM/1.5 (19056 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 198 MB / 1888 MB (25 MB allocated, but free)
Java version: 21.0.2+13-LTS, Eclipse Adoptium, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:55697, -ea, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.io=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/java.text=ALL-UNNAMED, --add-opens=java.base/java.util=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.desktop/java.awt=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-modules=java.scripting,java.sql, -javaagent:D:\eclipse-java-2020-09\eclipse\configuration\org.eclipse.osgi\3603\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8, -Dstdout.encoding=UTF-8, -Dstderr.encoding=UTF-8]

Plugins:
+ OpeningHoursEditor (36241)
+ RoadSigns (36226)
+ apache-commons (36176)
+ buildings_tools (36226)
+ comfort0 (36200)
+ ejml (36176)
+ geotools (36176)
+ jackson (36176)
+ jaxb (36118)
+ jts (36004)
+ o5m (36126)
+ opendata (36200)
+ pbf (36176)
+ poly (36126)
+ reltoolbox (36241)
+ reverter (36241)
+ undelete (36226)
+ utilsplugin2 (36241)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ d:\java_tools\JOSM\myhnr.mapcss

Last errors/warnings:
- 00000.617 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.620 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.620 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'

[GerdP]

CS-Manager before update

[GerdP]

CS-Manager after manual update

[GerdP]

Log before manunal update:

2024-04-25 09:00:38.390 INFO: GET https://api.openstreetmap.org/api/0.6/way/37407704/history -> HTTP/1.1 200 (175 ms)
2024-04-25 09:00:38.541 INFO: GET https://api.openstreetmap.org/api/0.6/changesets?changesets=1770190,16412412,79214306 -> HTTP/1.1 200 (136 ms; 636 B)
2024-04-25 09:00:40.660 INFO: GET https://api.openstreetmap.org/api/0.6/changeset/79214306 -> HTTP/1.1 200 (38 ms)

This happens with the manual update:

2024-04-25 09:01:17.971 INFO: GET https://api.openstreetmap.org/api/0.6/changeset/79214306?include_discussion=true -> HTTP/1.1 200 (117 ms)

[GerdP]

This seems to be an error in the OSM API. The response for the single get says comments_count="0" while the multiget for the same cs says comments_count="1":

f:\osm>curl https://api.openstreetmap.org/api/0.6/changeset/79214306
<?xml version="1.0" encoding="UTF-8"?>
<osm version="0.6" generator="CGImap 0.9.1 (2131594 spike-08.openstreetmap.org)" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
 <changeset id="79214306" created_at="2020-01-05T14:39:30Z" closed_at="2020-01-05T14:40:09Z" open="false" user="Chenshi" uid="114430" min_lat="52.3942212" min_lon="8.1937004" max_lat="52.9121770" max_lon="9.2001523" comments_count="0" changes_count="5343">
  <tag k="comment" v="maxspeed"/>
  <tag k="created_by" v="JOSM/1.5 (15553 de)"/>
  <tag k="source" v="datenbestandbearbeitung"/>
 </changeset>
</osm>

f:\osm>curl https://api.openstreetmap.org/api/0.6/changesets?changesets=1770190,16412412,79214306
<?xml version="1.0" encoding="UTF-8"?>
<osm version="0.6" generator="OpenStreetMap server" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
<changeset id="79214306" created_at="2020-01-05T14:39:30Z" open="false" comments_count="1" changes_count="5343" closed_at="2020-01-05T14:40:09Z" min_lat="52.3942212" min_lon="8.1937004" max_lat="52.9121770" max_lon="9.2001523" uid="114430" user="Chenshi">
  <tag k="comment" v="maxspeed"/>
  <tag k="created_by" v="JOSM/1.5 (15553 de)"/>
  <tag k="source" v="datenbestandbearbeitung"/>
</changeset>
<changeset id="16412412" created_at="2013-06-03T20:19:36Z" open="false" comments_count="0" changes_count="824" closed_at="2013-06-03T21:21:05Z" min_lat="52.3043748" min_lon="8.3182509" max_lat="53.0073317" max_lon="8.8552433" uid="114430" user="Chenshi">
  <tag k="comment" v="verschiedenes"/>
  <tag k="created_by" v="JOSM/1.5 (5939 de) Windows XP 32-Bit"/>
</changeset>
<changeset id="1770190" created_at="2009-07-08T09:35:19Z" open="false" comments_count="0" changes_count="210" closed_at="2009-07-08T09:35:48Z" min_lat="52.6320382" min_lon="8.4431387" max_lat="52.9756773" max_lon="8.7159137" uid="128495" user="Painter2009">
  <tag k="comment" v="Ellerchenh,Heideloh,Natenstedt,Heiligenloh"/>
  <tag k="created_by" v="JOSM/1.5 (1607 de)"/>
</changeset>
</osm>

[mmd]

Follow up on OSM API side in CGImap issue: ​https://github.com/zerebubuth/openstreetmap-cgimap/issues/401

[GerdP]

quick hack to always download changeset discussions

[GerdP]

I don't know how long it will take to fix the error in the OSM API. There is already a pull request. Anyhow I wonder why the Changeset manager doesn't always download the discussion. This patch would achive that.

[mmd]

We need to release a new CGImap 0.9.2 version and deploy it to production. Dev instance already has the fix.

[mmd]

Fix is in production now.

[GerdP]

@mmd: thanks

[GerdP]

BTW: Today I found out that JOSM has a side panel for Changesets. No idea if anybody uses it but it has an action to open the Changeset manager dialog for a selection of changesets. This operation might suffer from 23642-2.patch. On the other hand it could be changed to use the multifetch.