Modify

Opened 4 months ago

Last modified 3 months ago

#23404 new enhancement

ID style some bug

Reported by: jmxtzgbv9 Owned by: team
Priority: normal Milestone:
Component: External mappaint style Version:
Keywords: ID style Cc: Klumbumbus

Description (last modified by taylor.smock)

iD style missing some style,for example:

All highway no tunnel style.(But in iD edtior have)

ridge and valley color are #8CD05F.

piste:type line's color are #AA99DD.

if them can were fixed. I'd appreciate it.

Attachments (0)

Change History (7)

comment:1 by jmxtzgbv9, 4 months ago

Description: modified (diff)

comment:2 by taylor.smock, 4 months ago

Component: CoreExternal mappaint style
Description: modified (diff)
Milestone: Longterm
Version: latest

It looks like you've modified wiki:Styles/iD in the past. Have you considered making further modifications yourself?

If you aren't particularly familiar with MapCSS, wiki:Help/Styles/MapCSSImplementation has some good documentation.

For example, for piste:type, I would have a rule something like way["piste:type"]{color: #AA99DD;}

comment:3 by skyper, 4 months ago

Cc: Klumbumbus added
Type: defectenhancement

@jmxtzgbv9:
I am sorry but I had to revert you last change as it was broken.

  • For the valley and ridge you need to adjust the color for way[natural=ridge] { and way[natural=valley] {. Last time you modified the rendering of the nodes which are deprecated.
  • If some military=* have some new color, you need to create a new code block with the tags. Last time you did insert the new color within a block which damaged the whole style.
  • piste:type is a bit more tricky. At least highways should not be overridden ([!highway]) and we have colors for piste:difficulty at z-index -1. Was the support for piste:difficulty dropped in iD? Is this only about ways without highway=* And how to handle ways with highway=* and piste:type but without piste:difficulty:
    area[piste:type][!highway][!piste:difficulty][area=yes]::core_piste {
        fill-color: piste_type#aa99dd;
    }
    way[piste:type][!highway]::core_piste {
    width=3
    color: piste_type#aa99dd;
    }
    way[piste:type][highway][!piste:difficulty]::core_piste {
        z-index: -1; /* below line style from highway=* tag */
        modifier: false; /* suppress default line if there is no style on default layer */
        width: 6;
        color: piste_type#aa99dd;
    }
    
    Maybe even different widths per zoom level are useful for the ways without highway=*

in reply to:  3 ; comment:4 by anonymous, 4 months ago

Replying to skyper:

@jmxtzgbv9:
I am sorry but I had to revert you last change as it was broken.

  • For the valley and ridge you need to adjust the color for way[natural=ridge] { and way[natural=valley] {. Last time you modified the rendering of the nodes which are deprecated.
  • If some military=* have some new color, you need to create a new code block with the tags. Last time you did insert the new color within a block which damaged the whole style.
  • piste:type is a bit more tricky. At least highways should not be overridden ([!highway]) and we have colors for piste:difficulty at z-index -1. Was the support for piste:difficulty dropped in iD? Is this only about ways without highway=* And how to handle ways with highway=* and piste:type but without piste:difficulty:
    area[piste:type][!highway][!piste:difficulty][area=yes]::core_piste {
        fill-color: piste_type#aa99dd;
    }
    way[piste:type][!highway]::core_piste {
    width=3
    color: piste_type#aa99dd;
    }
    way[piste:type][highway][!piste:difficulty]::core_piste {
        z-index: -1; /* below line style from highway=* tag */
        modifier: false; /* suppress default line if there is no style on default layer */
        width: 6;
        color: piste_type#aa99dd;
    }
    
    Maybe even different widths per zoom level are useful for the ways without highway=*

I'm,sorry. But,how to reate a new code block with the tags?

in reply to:  4 ; comment:5 by skyper, 4 months ago

Oh, I forgot to mention that the right click menu in the Map Paint Style panel offers to save any style as a local file to modify and test it, locally.

Replying to anonymous:

I'm,sorry. But,how to create a new code block with the tags?

Delete the line with the tag in its current block and add e.g.:

area[military=danger_area] {
    fill-color: military#ff5555;
}

in reply to:  5 comment:6 by anonymous, 3 months ago

Replying to skyper:

Oh, I forgot to mention that the right click menu in the Map Paint Style panel offers to save any style as a local file to modify and test it, locally.

Replying to anonymous:

I'm,sorry. But,how to create a new code block with the tags?

Delete the line with the tag in its current block and add e.g.:

area[military=danger_area] {
    fill-color: military#ff5555;
}

And,why watreway no tunnel style, too?

in reply to:  3 comment:7 by jmxtzgbv9, 3 months ago

Replying to skyper:

@jmxtzgbv9:
I am sorry but I had to revert you last change as it was broken.

  • For the valley and ridge you need to adjust the color for way[natural=ridge] { and way[natural=valley] {. Last time you modified the rendering of the nodes which are deprecated.
  • If some military=* have some new color, you need to create a new code block with the tags. Last time you did insert the new color within a block which damaged the whole style.
  • piste:type is a bit more tricky. At least highways should not be overridden ([!highway]) and we have colors for piste:difficulty at z-index -1. Was the support for piste:difficulty dropped in iD? Is this only about ways without highway=* And how to handle ways with highway=* and piste:type but without piste:difficulty:
    area[piste:type][!highway][!piste:difficulty][area=yes]::core_piste {
        fill-color: piste_type#aa99dd;
    }
    way[piste:type][!highway]::core_piste {
    width=3
    color: piste_type#aa99dd;
    }
    way[piste:type][highway][!piste:difficulty]::core_piste {
        z-index: -1; /* below line style from highway=* tag */
        modifier: false; /* suppress default line if there is no style on default layer */
        width: 6;
        color: piste_type#aa99dd;
    }
    
    Maybe even different widths per zoom level are useful for the ways without highway=*

in iD, give up support for piste:difficulty dropped.(add That tag just a white line.)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to jmxtzgbv9.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.