History dialog doesn't show changes from imported OSC file

[mikedld]

What steps will reproduce the problem?

1. Make changes in Vespucci, export as OSC
2. Open OSC file in JOSM
3. Select modified node/way and open its history (Ctrl+H)

What is the expected result?

History dialog shows all previous versions and currently modified version at the end.

What happens instead?

History dialog shows all previous versions but no currently modified version. At the same time, enabling "Modified objects" map paint style correctly highlights modified nodes/ways, and they have correct (modified) position and tags. Upload dialog also shows all changes correctly.

After saving changes as .osm and re-opening the new file, the behavior remains the same.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-08-29 13:38:40 +0200 (Tue, 29 Aug 2023)
Revision:18822
Build-Date:2023-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18822 en) Linux Gentoo Linux
Memory Usage: 4096 MB / 4096 MB (1191 MB allocated, but free)
Java version: 11.0.20.1+1, Gentoo, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: es_ES.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_ES
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.library.path=/lib:/usr/lib, -Dswing.aatext=TRUE, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.2.0)
+ MicrosoftStreetside (36194)
+ PicLayer (1.0.3)
+ PolygonCutOut (v0.7.3)
+ ShapeTools (1250)
+ apache-commons (36176)
+ apache-http (36176)
+ buildings_tools (36178)
+ ejml (36176)
+ geotools (36176)
+ imagery_offset_db (36126)
+ importvec (35995)
+ indoorhelper (1.2.3)
+ jackson (36176)
+ javafx (36178)
+ jaxb (36118)
+ jna (36176)
+ jogl (1.2.3)
+ jts (36004)
+ kendzi3d (1.0.205)
+ kendzi3d-resources (0.0.2)
+ log4j (36176)
+ lwjgl (36176)
+ lwjgl-unixoid (36176)
+ opendata (36186)
+ openindoor-1.0.2-josm (UNKNOWN)
+ openqa (v0.3.3)
+ reltoolbox (36178)
+ reverter (36126)
+ scripting
+ undelete (36126)
+ utilsplugin2 (36178)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Addr2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- <josm.userdata>/plugins/indoorhelper/resources/sit.mapcss

Last errors/warnings:
- 42249.929 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42249.952 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42249.972 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42250.051 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42250.073 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42250.193 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42250.314 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42251.101 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42251.315 W: Not downloading all tiles because there is more than 40 tiles on an axis!
- 42251.476 W: Not downloading all tiles because there is more than 40 tiles on an axis!

[taylor.smock]

@mikedld: Can you upload an OSC from Vespucci?

[mikedld]

Done @taylor.smock

[gaben]

Hmm, there are known issues with the history tab, this seems to be just a new example. I don't have ticket numbers right now though.

[mattmccutchen]

XSLT to add changeset metadata to OSM file as a workaround

[mattmccutchen]

XSLT to add changeset metadata to OSM or OSC file as a workaround (revision 2)

[mattmccutchen]

I ran into the same problem, and I think I found the cause. In OSM and OSC files generated by Vespucci, elements do not contain the user, uid, and changeset fields. This causes an exception to be thrown here, and the history dialog box omits the currently modified version. I don't know the best way to fix this.

As a workaround, I wrote an XSL transform (attached) to add the missing fields to a Vespucci-generated OSM or OSC file using dummy values before I open the file in JOSM. It's a hack, but it should unblock me. In brief testing, I didn't see JOSM actually use the dummy values for anything.