Modify ↓

Opened 2 years ago

Last modified 2 years ago

#23379 new defect

The edit-relation screen looses changes

Reported by: blackboxlogic@… Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: relation editor textbox save Cc:

Description (last modified by skyper)

The edit-relation window looses changes, depending on the order the user focuses controls.

Steps to reproduce:

  • Open the edit-relation window for an existing relation
  • click on an existing tag, and change its value
  • Without moving focus to another control, use the mouse to close the window (clicking the top right X)
  • Re-open the edit-relation window and see that your changes aren't there.

The problem is that the control never loses focus so the value isn't saved or marked as dirty.

I'm on Windows 10, installed JOSM through the windows app store (I know), running JOSM v18822

Attachments (0)

Change History (5)

comment:1 by blackboxlogic@…, 2 years ago

Additional details:

Revision:18822
Build-Date:2023-08-30 11:44:32

Identification: JOSM/1.5 (18822 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 2038 MB / 4068 MB (637 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 3840×2160 (scaling 2.00×2.00)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→64×64, 32×32→64×64
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18822, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.2.0)
+ PicLayer (1.0.3)
+ apache-commons (36176)
+ apache-http (36176)
+ ejml (36176)
+ geotools (36176)
+ jackson (36176)
+ jaxb (36118)
+ jna (36176)
+ jts (36004)
+ measurement (36126)
+ opendata (36186)
+ pbf (36176)
+ poly (36126)
+ reverter (36126)
+ todo (133)
+ undelete (36126)
+ utilsplugin2 (36178)

Tagging presets:
+ %UserProfile%\Desktop\DrivewayPreset.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- %UserProfile%\Desktop\Render a Field as Text.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ %UserProfile%\AppData\Local\JOSM\customMapcss.txt

Last errors/warnings:
- 00000.702 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.705 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.952 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00012.914 E: Skipping to the next rule, because of an error: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " "|z" "|z "" at line 32, column 16.
- 103439.011 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 103549.751 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 116626.704 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 116667.153 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>

comment:2 by taylor.smock, 2 years ago

Identification: JOSM/1.5 (18822 en) Windows 10 64-Bit

Can you try with r18932?

With that said, I think the behavior you describe is still present in r18932 (I'm assuming what I reproduced is what you encountered). We should ask the user about Unsaved changes if the user has modified text in a textbox.

comment:3 by skyper, 2 years ago

The behavior is present for a long time. Thought I had reported it a long time ago but maybe not.

comment:4 by skyper, 2 years ago

Keywords: relation editor textbox save added

comment:5 by skyper, 2 years ago

Description: modified (diff)
Summary: The edit-relation screen loses changes → The edit-relation screen looses changes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to blackboxlogic@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.