Opened 2 years ago
Last modified 2 years ago
#23344 new defect
After correcting errors flagged by pre-upload validation, restarting upload does not clear the highlights
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | tested |
| Keywords: | template_report | Cc: | SekeRob |
Description
What steps will reproduce the problem?
- Prepare to upload edits
- Exit the process and correct errors/warnings where needed which are listed in the Validation Results pane.
- Start the upload process again.
What is the expected result?
Pre 18905 the errors/warnings that were corrected have their highlight on the map removed and cleared from the validation result pane
What happens instead?
The corrected errors/warnings remain in highlight state and are not removed from the validations results pane giving the false impression as were error corrections missed.
Please provide any additional information below. Attach a screenshot if possible.
Notably, when hitting the general Shift+V keys the corrected highlights are cleared, something the pre-upload process would do with stable 18822 and before.
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-12-07 13:35:12 +0100 (Thu, 07 Dec 2023)
Revision:18907
Build-Date:2023-12-07 16:38:49
URL:https://josm.openstreetmap.de/svn/trunk
Identification: JOSM/1.5 (18907 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 4084 MB / 4084 MB (1978 MB allocated, but free)
Java version: 21.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, -Djava.security.manager=allow]
Dataset consistency test: No problems found
Plugins:
+ KartaView (490)
+ Mapillary (2.2.0)
+ OpeningHoursEditor (36126)
+ Relation.Validation.Plugin (1.0.1)
+ RoadSigns (36126)
+ apache-commons (36176)
+ easypresets (1623509627)
+ editgpx (36126)
+ ejml (36176)
+ graphview (36178)
+ gridify (1606242219)
+ jaxb (36118)
+ jogl (1.2.3)
+ kendzi3d-resources (0.0.2)
+ log4j (36176)
+ lwjgl (36176)
+ lwjgl-windows (36176)
+ measurement (36126)
+ notesolver (0.5.0)
+ pmtiles (36156)
+ pt_assistant (632)
+ reltoolbox (36178)
+ reverter (36126)
+ rex (53)
+ routing (36178)
+ tageditor (36126)
+ todo (133)
+ turnlanes (36126)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36178)
+ utilsplugin2 (36178)
Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ <josm.pref>/EasyPresets.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
- https://josm.openstreetmap.de/wiki/Styles/Waterways
- https://josm.openstreetmap.de/josmfile?page=Styles/Waterways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&style
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/ItalySpecific&zip=1
Last errors/warnings:
- 13629.958 W: Relation 'multipolygon (11944075, 0 members) [id: 11,944,075]' is already deleted. Skipping object in upload.
- 13630.412 E: Error header: The relation with the id 13457086 has already been deleted
- 13630.522 W: Relation 'multipolygon (13457086, 0 members) [id: 13,457,086]' is already deleted. Skipping object in upload.
- 13631.008 E: Error header: The way with the id 1193311881 has already been deleted
- 13631.118 W: Way 'service (highway) (0 nodes) [id: 1,193,311,881]' is already deleted. Skipping object in upload.
- 14426.704 W: Warning - Cannot merge nodes: Would have to delete way <ul><li>Via Leonardo Petruzzi (2 nodes) [id: 836,877,566]</li></ul> which is still used by <ul><li>route ("Strada Provinciale 1 Marina-Elice", 78 members, incomplete) [id: 12,195,255]</li><li>restriction ("only_straight_on", 3 members) [id: 11,501,272]</li></ul>
- 14452.013 W: Unable to request focus for org.openstreetmap.josm.gui.tagging.ac.AutoCompletingTextField[,0,0,319x17,layout=javax.swing.plaf.basic.BasicTextUI$UpdateHandler,alignmentX=0.0,alignmentY=0.0,border=javax.swing.border.EmptyBorder@13a399c3,flags=296,maximumSize=,minimumSize=,preferredSize=,caretColor=sun.swing.PrintColorUIResource[r=51,g=51,b=51],disabledTextColor=javax.swing.plaf.ColorUIResource[r=184,g=207,b=229],editable=true,margin=javax.swing.plaf.InsetsUIResource[top=0,left=0,bottom=0,right=0],selectedTextColor=sun.swing.PrintColorUIResource[r=51,g=51,b=51],selectionColor=javax.swing.plaf.ColorUIResource[r=184,g=207,b=229],columns=0,columnWidth=0,command=,horizontalAlignment=LEADING]
- 14465.236 W: Warning - Cannot merge nodes: Would have to delete way <ul><li>Via Leonardo Petruzzi (2 nodes) [id: 836,877,566]</li></ul> which is still used by <ul><li>route ("Strada Provinciale 1 Marina-Elice", 78 members, incomplete) [id: 12,195,255]</li></ul>
- 29229.620 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 29229.629 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>
Attachments (0)
Change History (4)
comment:1 by , 2 years ago
| Owner: | changed from to |
|---|
comment:2 by , 2 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
comment:3 by , 2 years ago
comment:4 by , 2 years ago
| Component: | Core → Core validator |
|---|



Also mentioned in ticket:23051#comment:5.