The test plugin dummy_plugin.v31772.jar does not plug

[marcello@…]

The plugin test/data/__files/plugin/dummy_plugin.v31772.jar does not load because it throws:

java.lang.ClassNotFoundException: org.openstreetmap.josm.gui.NameFormatterHook

and has done so since 2017-08-25. See #15182 - move NameFormatter* from gui to data.osm

This plugin is used by many tests ... so much for testing.

[stoecker]

This plugin is used an 3 places and none of these tests the plugin loader, so who cares if the plugin loads or now. It's simply not the task of that plugin to be loaded (which should be obvious already seeing the name).

[marcello@…]

It is not immediately clear to me that a "Dummy-plugin" is broken to the point that it doesn't even load.

If this is intentional, it should be renamed "Broken-plugin" or "Broken-since-15182-plugin".

If this is not intentional it should be replaced by another more sane plugin.

Your answer is not very encouraging for people who try to write tests (that's how I found out: while writing the yet missing unit test for PluginHandler.loadPlugin). I believe that you should take the integrity of the testing system a bit more seriously.

[stoecker]

If you want to write a new test for yet untested functionality that's fine, but existing tests typically aren't modified until they break because software changes its functionality. Test data, and nothing else is the dummy plugin, is also typically stripped to the bare minimum representing certain aspects.

If your new tests require the plugin to work then you can adapt the plugin and provide this together with the new test. If that does not break existing tests then that will be applied. But a ticket about a test data set not fulfilling some functionality, which is not needed for the tests it is used for, simply serves no purpose.