[PATCH] JCSCacheManager locks the wrong directory

[marcello@…]

In org.openstreetmap.josm.data.cache.JCSCacheManager the cache manager always acquires a lock on the <cachedir>/jcs directory regardless of the cachePath passed to the getCache function. In normal use this doesn't matter.

When unit-testing this prevents tests like JCSCacheManagerTest::testUseBigDiskFile to run concurrently with other tests, notwithstanding that this test uses a different cache directory of foobar and should thus be able to acquire a lock on this directory.

[marcello@…]

patch

[taylor.smock]

I'm actually wondering if we need the file lock still -- we use JCS, and there have been many updates to it since that code was originally written back in 2015 (see #11312/r8186). ImageryCache has been in core since r8772, so the original reason for that code is no longer relevant as well.

A brief test did not show that it was still necessary.