[patch] Ignore line_management=transition|termination in UnconnectedPower test

[gaben]

What steps will reproduce the problem?

1. Load the test file
2. Validate the data

What is the expected result?

No warning, as the end nodes are not meant to be directly connected

What happens instead?

Three warnings.

Please provide any additional information below. Attach a screenshot if possible.

​Key:line_management

src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java

@@ -201 +201 @@
 
         @Override
         protected boolean ignoreUnconnectedEndNode(Node n) {
-            return n.hasTag("power", "terminal") || n.hasTag("location:transition", "yes");
+            return n.hasTag("power", "terminal") || n.hasTag("location:transition", "yes") || n.hasTag("line_management", "transition", "termination");
         }
     }

Revision:18882
Is-Local-Build:true
Build-Date:2023-10-29 20:41:39

[gaben]

add wiki link

[francois.lacombe]

Hi

I couldn't agree more, it's a good point.

I don't see any possible addition by the way, it's ok.

[gaben]

Thank you for the input!

[taylor.smock]

In 18885/josm:

Fix #23252: Ignore line_management=transition|termination in UnconnectedPowerTest (patch by gaben, modified)

Modifications are as follows:

• Lint fixes
• Performance enhancements (profiling done with validator and an overpass download of Mesa County, Colorado)
  • Iterating over an array is much more efficient than using streams. For methods that may be frequently called, using Arrays.stream is currently not a good idea.
    • hasTagDifferent: 2.09 MB -> 0
    • hasTag: 125MB -> 0
    • hasKey: 879MB -> 0

[taylor.smock]

Ticket retargeted after milestone deleted