When running an "Update Data" from File menu all data parts that previously where purged are pulled back in.

[SekeRob]

What steps will reproduce the problem?

1. Open (large) data set from previous day
2. Purge areas no longer of interest by selecting what can go
3. Hit Shift+Ctrl+P and purge that data.
4. Run 'Updata data' to ensure that what is still in the active data set matches that's what's on the server.
5. The data from steps 2-3 reappears.

What is the expected result?

Only the remaining data is server checked and updated if changed.

What happens instead?

Step 5, the purged data reappears as were it not forgotten.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-08-29 13:38:40 +0200 (Tue, 29 Aug 2023)
Revision:18822
Build-Date:2023-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18822 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 4084 MB / 4084 MB (1867 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ KartaView (413)
+ Mapillary (2.2.0)
+ OpeningHoursEditor (36126)
+ Relation.Validation.Plugin (1.0.1)
+ RoadSigns (36126)
+ apache-commons (36176)
+ easypresets (1623509627)
+ editgpx (36126)
+ ejml (36176)
+ graphview (36178)
+ gridify (1606242219)
+ jaxb (36118)
+ kendzi3d-dev
+ kendzi3d-resources (0.0.2)
+ log4j (36176)
+ lwjgl (36176)
+ lwjgl-windows (36176)
+ notesolver (0.5.0)
+ pmtiles (36125)
+ pt_assistant (630)
+ reltoolbox (36178)
+ reverter (36126)
+ rex (53)
+ routing (36178)
+ tageditor (36126)
+ todo (133)
+ turnlanes (36126)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36178)
+ utilsplugin2 (36178)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ <josm.pref>/EasyPresets.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&style
+ https://josm.openstreetmap.de/wiki/Styles/Waterways
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip

Last errors/warnings:
- 27607.031 W: Way '‎service (highway)‎ (0 nodes) [id: 1,193,311,881]‌' is already deleted. Skipping object in upload.
- 28055.147 E: Error header: The relation with the id 11944075 has already been deleted
- 28055.254 W: Relation 'multipolygon (11944075, 0 members) [id: 11,944,075]' is already deleted. Skipping object in upload.
- 28055.701 E: Error header: The way with the id 977349318 has already been deleted
- 28055.805 W: Way '‎977349318‎ (0 nodes) [id: 977,349,318]‌' is already deleted. Skipping object in upload.
- 28105.403 W: Deleted or moved objects - <html>There are 9 objects in your local dataset which might be deleted on the server.<br>If you later try to delete or update them the server is likely to report a conflict.<br>Click <strong>Check on the server</strong> to check the state of these objects on the server.<br>Click <strong>Ignore</strong> to ignore.</html>
- 29477.248 W: Unable to delete archived backup file <josm.pref>\autosave\deleted_layers\01 Italy repairs.osm_20231028_090755400.osm
- 29483.208 W: Unable to delete archived backup file <josm.pref>\autosave\deleted_layers\01 Italy repairs.osm_20231028_091025401.osm
- 32549.002 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 35390.128 W: Deleted or moved objects - <html>There are 8 objects in your local dataset which might be deleted on the server.<br>If you later try to delete or update them the server is likely to report a conflict.<br>Click <strong>Check on the server</strong> to check the state of these objects on the server.<br>Click <strong>Ignore</strong> to ignore.</html>

[stoecker]

"Update data" downloads the previously downloaded areas. What you want is to use either "Update selected" or "Update modified".

[SekeRob]

Did see now that even when doing the Shft+Ctrl+P to forget/purge an area of data, the hatching does not return there i.e. still regarded as a downloaded area.

It's a pity, the other 2 options don't update the data pre-editing unless selected which for large data sets is practically never completing, no time out than needing to kill JOSM and the modified really is after the fact, seeing and seen conflict resolution requirements, being a hard call, take my edit or take their edit while working in the same zone which is happening presently on a forest relation that grew to 2300 members over time, like 10 years. Got it down to 1870 simplifying the outlines, but the planned splitting is going to take time, more conflict potential.

[stoecker]

Issue is that updating element tales a LOOOONG time, as each element must be updated individually (one request per element).

I suggest you try to change your workflow and not purge elements, but rather use the display filters. That way you can use Update Data. Essentially Purge is only meant to create specific minimal output files for post-processing (i.e. map making).

[SekeRob]

Suppose the bug label would need conversion to feature of something like Update active data but for one user that is more of a bottom of the reverse polish todo stack. :o)

Thanks for the advise, display filters, if that is Alt-Shft-F, I'd need to learn what it does. Hiding that what is not of momentary interest is nice, the Inverse, only showing that of interest even better, it having been mapped shown with that darkish outline good as do certainly not want to remap the mapped. If this filter stops pulling in same on Update Data then it certainly would cut down on the data being refreshed.

[stoecker]

Replying to SekeRob:

Suppose the bug label would need conversion to feature of something like Update active data but for one user that is more of a bottom of the reverse polish todo stack. :o)

That would be a wontfix, as that's what update selection and Update modified do. As long as the server has no API to download multiple IDs in one go you have only the chance to update area based or take the slow way.

Thanks for the advise, display filters, if that is Alt-Shft-F, I'd need to learn what it does. Hiding that what is not of momentary interest is nice, the Inverse, only showing that of interest even better, it having been mapped shown with that darkish outline good as do certainly not want to remap the mapped. If this filter stops pulling in same on Update Data then it certainly would cut down on the data being refreshed.

It doesn't stop pulling in data, but you're only seeing the parts you want to see, so the filtered elements don't bother you (but the are there, so safety mechanisms will work and tell you when badly you affect filtered data). It's the recommended way to cope with the overfull dataset of nowadays maps.