Geotagged images icon disappear

[OSM_Pontarlier]

What steps will reproduce the problem?

1. With plugin "photoadjust" installed, drag and drop images on JOSM.
2. Adjust photo location (usually with ALT + clicking to the right position)
3. Photo that are moved ~100m+ away from their original location have their icon made invisible, until you zoom out OR have the image selected (→ red icon).

What is the expected result?

Photo icons remains visible.

What happens instead?

It's hidden.

Please provide any additional information below. Attach a screenshot if possible.

See ​https://mstdn.social/@OSM_Pontarlier/111262871395130473

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-08-29 13:38:40 +0200 (Tue, 29 Aug 2023)
Revision:18822
Build-Date:2023-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18822 fr) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 3172 MB / 4068 MB (1221 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.nimbus.NimbusLookAndFeel
Screen: \Display0 3440×1440 (scaling 1.00×1.00)
Maximum Screen Size: 3440×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: fr_FR
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=E:\Program Files\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]

Plugins:
+ FastDraw (36126)
+ OpeningHoursEditor (36126)
+ PicLayer (1.0.3)
+ alignways (36126)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36134)
+ cadastre-fr (36126)
+ conflation (0.6.11)
+ continuosDownload (102)
+ contourmerge (v0.2.0)
+ ejml (35924)
+ geotools (36068)
+ gridify (1606242219)
+ jackson (36034)
+ jaxb (36118)
+ jna (36126)
+ jts (36004)
+ measurement (36126)
+ opendata (36126)
+ photo_geotagging (36126)
+ photoadjust (36126)
+ reverter (36126)
+ scripting (v0.3.0)
+ shrinkwrap (v1.0.4)
+ tageditor (36126)
+ terracer (36126)
+ todo (133)
+ turnlanes-tagging (0.0.5)
+ undelete (36126)
+ utilsplugin2 (36134)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/FR.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Surveillance&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MastAndTower&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/FixmeAndNote&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/light_source&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1

Last errors/warnings:
- 02324.907 W: Already here java.net.SocketTimeoutException: Connect timed out
- 02345.424 W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- 02345.425 W: Already here java.net.SocketTimeoutException: Connect timed out
- 02346.518 W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- 02346.519 W: Already here java.net.SocketTimeoutException: Connect timed out
- 02346.830 W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- 02346.830 W: Already here java.net.SocketTimeoutException: Connect timed out
- 03577.159 E: java.io.FileNotFoundException: D:\Partage\Captures\2019_09_11_16_41_23_518_+0200\A.jpg (Le fichier spécifié est introuvable)
- 03608.047 E: Handled by bug report queue: java.lang.NullPointerException: Cannot invoke "org.openstreetmap.josm.data.coor.CachedLatLon.getEastNorth(org.openstreetmap.josm.data.projection.Projecting)" because the return value of "org.openstreetmap.josm.gui.layer.geoimage.ImageEntry.getPos()" is null
- 03613.244 E: java.io.FileNotFoundException: D:\Partage\Captures\2019_09_11_16_41_23_518_+0200\A.jpg (Le fichier spécifié est introuvable)

[taylor.smock]

I haven't been able to reproduce. But I think I see (at least part of) the problem:

• 03608.047 E: Handled by bug report queue: java.lang.NullPointerException: Cannot invoke "org.openstreetmap.josm.data.coor.CachedLatLon.getEastNorth(org.openstreetmap.josm.data.projection.Projecting)" because the return value of "org.openstreetmap.josm.gui.layer.geoimage.ImageEntry.getPos()" is null

I haven't seen another ticket with that NPE as the cause. Without the stack trace, I don't think I can fix the problem if I cannot reproduce. You may have seen a bug report window previously and hid the exception; if you did that, please don't do that. Always report the bug.

[anonymous]

Hi! The same bug occurred today, without any bug or window announcing a crash. Any idea how can I help more?

[taylor.smock]

You can try running JOSM with the command-line --debug flag.

[anonymous]

I'm not familiar with that at all, so I did "E:\Program Files\OpenWebStart\javaws.exe" "https://josm.openstreetmap.de/download/josm.jnlp" --debug

Here's a state report. I don't know if that somewhat helps. 😅
(Had to paste it here, I couldn't post it here, too many characters)

​https://privatebin.net/?08ceb806658d7754=#qqbvm6hqaiXyrgCmmBveTxK54KL26A8NHSxfFKEjFe3

[taylor.smock]

It should be logging to console. If you don't see anything in the console that you started JOSM with, you might need to go into OpenWebStart settings -> Logging -> Log Console should be Show. You can also take at the log folder and see if there is anything useful in there. I'm looking for something that looks like

java.lang.NullPointerException
	at org.openstreetmap.josm.data.Preferences.removeAndUpdateObsolete(Preferences.java:903)
	at org.openstreetmap.josm.data.Preferences.load(Preferences.java:488)
	at org.openstreetmap.josm.data.Preferences.init(Preferences.java:608)
	at org.openstreetmap.josm.gui.MainApplication.mainJOSM(MainApplication.java:825)
	at org.openstreetmap.josm.gui.MainApplication$3.processArguments(MainApplication.java:277)
	at org.openstreetmap.josm.gui.MainApplication.main(MainApplication.java:742)

[anonymous]

Okay thanks. So the folder contains a .log file (last edited on 2023-09-22) with content "Exception while logging".
Then I started JOSM that displayed a first console window:
​https://privatebin.net/?e4d50bcd3b13927c=#2rrzaVjYi5S9ee8T1ZFeCEwgkKZyyGjPJkNJqzkSQxg8

And another one:
​https://privatebin.net/?4f61f1cfdf5d2ab5#8dQyJ1NqnTQR9CU25UYdGXgpr9HRzVwB1gmmtBwbQCBJ

The link above also contains all the steps I followed in order to repeat the bug. (And it successfully bugged)

[taylor.smock]

FML. Neither one has a stack trace, so that is probably not the cause. A screen capture showing what you are doing might help. It is entirely possible that I misunderstood the steps to reproduce.

Specifically, I did the following:

1. Install photoadjust plugin and restart JOSM
2. Drag-n-drop images into JOSM
3. Click on an image
4. Adjust photo location (>100m)
5. Deselect the photo
6. Check to see if the photo is still visible

[anonymous]

Haha, complicated right? Next time I will find an easier bug
Here's a video to understand the steps ​https://video.liberta.vip/w/ph6pixZhHFJDqPA1Y92DaU and the folder used in the video (160 Mo) ​https://drop.chapril.org/download/737a505bec6668c6/#Jv01r_F_4W6rhdYp9P7Nhg

If it doesn't works in next to the roundabout, maybe retry from the beginning. Hope you will be able to reproduce it!

[taylor.smock]

In 36188/osm:

Fix #23241: Image icons disappear when moving them

When an image is moved, ImageData#updateImagePosition must be called in order
to reindex the image geographically.

Also fix some SonarLint issues.

[taylor.smock]

In 36189/osm:

See #23241 (dist): Image icons disappear when moving them

When an image is moved, ImageData#updateImagePosition must be called in order
to reindex the image geographically.

[anonymous]

Replying to anonym:

Haha, complicated right? Next time I will find an easier bug

Good luck with that. I've the feeling the easier ones are all gone ;-)

[anonymous]

Wow, I don't know yet if it's really fixed but good job & thank you Taylor!

Good luck with that. I've the feeling the easier ones are all gone ;-)

Hold my beer