Shortcut T has moved

[MKnight]

What steps will reproduce the problem?

1. Use Touchscreenhelper
2. Press T

What is the expected result?

want to move the screen with left finger

What happens instead?

nothing

Please provide any additional information below. Attach a screenshot if possible.

I have looked into the keyboardshortcuts and can see that the shortcut has moved to "mode: share mode" (Modus: Teilungsmodus)
(i have deactivated it und put it back to touchscreenhelper, but it cannot be that shortcuts are changing in releases?)

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-31 18:33:06 +0200 (Mon, 31 Jul 2023)
Revision:18789
Build-Date:2023-08-01 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18789 de) Linux Mint 21.2
Memory Usage: 640 MB / 5512 MB (224 MB allocated, but free)
Java version: 17.0.8+7-Ubuntu-122.04, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1366×768 (scaling 1.00×1.00)
Maximum Screen Size: 1366×768
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_DE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: MATE
Java package: openjdk-17-jre:amd64-17.0.8+7-1~22.04
libcommons-compress-java: libcommons-compress-java:all-1.21-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20201225-1build1
Program arguments: [${HOME}/OSm/JOSM/de-josm.joz]

Plugins:
+ Mapillary (2.1.5)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36097)
+ changeset-viewer (0.0.6)
+ continuosDownload (1.3.4)
+ ejml (35924)
+ geotools (36068)
+ gridify (1606242219)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ log4j (36045)
+ lwjgl (36034)
+ lwjgl-unixoid (36034)
+ opendata (36097)
+ reltoolbox (36103)
+ reverter (36066)
+ touchscreenhelper (35995)
+ turnrestrictions (36097)
+ undelete (36066)
+ utilsplugin2 (36097)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Addr2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Stolpersteine&zip=1
+ https://raw.github.com/Flacus/Windrad/master/windrad.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ ${HOME}/OSm/JOSM/eigene-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

[taylor.smock]

Looking at the wiki:DevelopersGuide/ShortcutsList page, T is used by the following actions:

• KnifeTool (auto_tools)
• SplitMode (JOSM, largely replaces KnifeTool; this is probably why the touchscreenhelper shortcut was automatically changed -- uses T since it was meant to replace KnifeTool from auto_tools)
• TracerAction (Tracer and Tracer2)
• BrowseAction (touchscreenhelper)

The hard part of adding new actions is creating a shortcut which does not exist. It is really hard (which you will see if you go through the alphabet on the linked list).

[MKnight]

Ok Splitmode is the problem, thx.
Why it was not merging with the existant split-function (P)?

[taylor.smock]

One is a tool; you are expected to have the node to split already selected.
The other is a mode; you are expected to click where you want to split.

At this time, it would be really hard to "share" a shortcut between a tool and a mode. It could be done, theoretically, but then we have behavior expectation problems. Example:

• I have a node selected, but want to go into the mode instead of splitting the way. P splits the way.
• I have a node selected, and want to split the way. P switches the mode.

I (personally) think it is less confusing to have separate keyboard shortcuts for both.