Modify ↓
Opened 2 years ago
Closed 2 years ago
#22880 closed enhancement (fixed)
[patch] Use a single log entry for MapCSS error logging
Reported by: | gaben | Owned by: | team |
---|---|---|---|
Priority: | trivial | Milestone: | 23.04 |
Component: | Core | Version: | |
Keywords: | mapcss log error_handling | Cc: |
Description (last modified by )
I noticed the issue when the edited MapCSS rule was invalid, see status report of #22878.
So instead
Last errors/warnings: - 00019.987 E: Skipping to the next rule, because of an error: - 00019.988 E: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " ":" ": "" at line 98, column 9.
Last errors/warnings: - 00019.987 E: Skipping to the next rule, because of an error: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " ":" ": "" at line 98, column 9.
should be printed.
The following patch fixes the above.
-
src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSParser.jj
1162 1162 e = new ParseException(pe.getMessage()); // prevent memory leak 1163 1163 } 1164 1164 1165 Logging.error("Skipping to the next rule, because of an error:"); 1166 Logging.error(e); 1165 Logging.error("Skipping to the next rule, because of an error: " + e); 1167 1166 if (sheet != null) { 1168 1167 sheet.logError(e); 1169 1168 }
Attachments (0)
Change History (2)
comment:1 by , 2 years ago
Description: | modified (diff) |
---|
comment:2 by , 2 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In 18712/josm: