Opened 3 years ago
Closed 8 months ago
#22879 closed defect (fixed)
Cut keyboard shortcuts doesn't work after reverting order of relation members
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 25.05 |
| Component: | Core | Version: | latest |
| Keywords: | Cc: |
Description
What steps will reproduce the problem?
- Open the relation editor for a relation of your choice
- Select a couple of relation members (e.g. click one of them, then shift+click another one)
- Click on the "Reverse the order of the relation members" button
- The order of the selected relation members will be reversed (as expected), and the members are still selected
- Try to cut (ctrl + x) the selected members (so you can then paste them somewhere else after)
- The cut shortcut has no effect.
What is the expected result?
In step 6, the selected members are cut from the member list, placed in the clipboard and can then be pasted elsewhere.
What happens instead?
see above - keyboard shortcut has no effect.
Please provide any additional information below. Attach a screenshot if possible.
- Cutting works as expected when the "reverse the order of the relation members" button is NOT being used between selecting the members and trying to cut them
- Copying the members works as expected, regardless whether the reverse button is being used prior to copying or not.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2023-04-11 19:04:13 +0200 (Tue, 11 Apr 2023) Revision:18702 Build-Date:2023-04-12 01:30:58 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18702 en) Windows 11 64-Bit OS Build number: Windows 10 Pro 2009 (22000) Memory Usage: 1000 MB / 8180 MB (679 MB allocated, but free) Java version: 20+36-2344, Oracle Corporation, OpenJDK 64-Bit Server VM Look and Feel: com.formdev.flatlaf.FlatDarkLaf Screen: \Display0 3840×2160 (scaling 1.50×1.50) \Display1 1920×1080 (scaling 1.00×1.00) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→48×48, 32×32→48×48 System property file.encoding: UTF-8 System property sun.jnu.encoding: Cp1252 Locale info: en_US Numbers with default locale: 1234567890 -> 1234567890 Dataset consistency test: No problems found Plugins: + ImproveOsm (238) + PicLayer (1.0.2) + apache-commons (36034) + buildings_tools (36011) + continuosDownload (105) + easypresets (1623509627) + ejml (35924) + flatlaf (36036) + geotools (36028) + http2 (35921) + imagery_offset_db (35978) + jackson (36034) + jaxb (35952) + jts (36004) + opendata (36025) + pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT) + reverter (36043) + tageditor (36011) + terracer (35978) + todo (123) + turnlanes-tagging (v0.0.5) + turnrestrictions (36011) + undelete (36011) + utilsplugin2 (36011) Tagging presets: + D:\osm\josm\mh_custom\presets\preset.xml + D:\osm\name_suggestion_index\dist\presets\nsi-josm-presets.xml + D:\osm\josm\mh_custom\presets\EasyPresets.xml + <josm.pref>/EasyPresets.xml Map paint styles: + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksPlus&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1 + D:\userdata\<user.name>\Desktop\foo.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1 Validator rules: + https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1 + https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip + https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1 + D:\userdata\<user.name>\Desktop\validations.validator.mapcss + https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip Last errors/warnings: - 00000.587 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF' - 00000.590 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00000.591 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF' - 00003.417 W: Unable to request certificate of https://roottest-ev.pkioverheid.nl - 00003.821 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl - 00004.172 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl - 00019.915 E: java.nio.file.NoSuchFileException: <josm.pref>\EasyPresets.xml - 00019.916 E: <josm.pref>/EasyPresets.xml - 00301.042 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
Attachments (1)
Change History (5)
comment:1 by , 3 years ago
comment:2 by , 8 months ago
I tried getting to the bottom of this - it looks like this is being caused by the cut action being inherited from JTable, while copy/paste are custom actions. The custom ones can deal with the underlying MemberTableModel changing, while the stock action cannot.
Proposed patch attached.
comment:3 by , 8 months ago
| Milestone: | → 25.05 |
|---|



Same for me.
Thanks for the hint about this, so far, undocumented shortcuts, see diff.