Changes between Initial Version and Version 1 of Ticket #22798


Ignore:
Timestamp:
2023-03-07T15:57:15+01:00 (3 years ago)
Author:
taylor.smock
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22798

    • Property Milestone → 23.04
    • Property Summary Convert actions which extend `AbstractAction` to ones which extend `JosmAction` → [PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction`

  • Ticket #22798 – Description

    initial v1  
    11We should try to ensure that all actions (especially those that some users may want to bind to shortcuts) extend `JosmAction`.
     2
     3The affected dialogs and actions are as follows:
     4* ChangesetDialog
     5 * SelectObjectsAction
     6 * ReadChangesetsAction
     7 * CloseOpenChangesetsAction
     8 * ShowChangesetInfoAction
     9 * LaunchChangesetManagerAction
     10* CommandStackDialog
     11 * SelectAction
     12 * SelectAndZoomAction
     13 * Undo/Redo actions (since these are distinct from the global undo/redo action -- will undo/redo to the selected command)
     14* FilterDialog
     15 * AddAction
     16 * EditAction
     17 * DeleteAction
     18 * MoveUpAction
     19 * MoveDownAction
     20 * SortAction
     21 * ReverseAction
     22* MapPaintDialog
     23 * OnOffAction
     24 * MoveUpDownAction
     25* NotesDialog
     26 * AddCommentAction
     27 * CloseAction
     28 * NewAction
     29 * ReopenAction
     30 * SortAction
     31 * OpenInBrowserAction
     32* RelationListDialog
     33 * NewAction
     34* UserListDialog
     35 * SelectUserPrimitivesAction
     36 * ShowUserInfoAction -- this calls a different `super` constructor actually
     37
     38I don't see most of these getting shortcuts, especially official shortcuts, but some people on various chat channels have mentioned that they would like to have a shortcut for creating a new relation.
     39
     40The current patch primarily focuses on actions for toggle dialogs.