Opened 3 years ago

Last modified 3 years ago

#22798 closed defect

[PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction` — at Version 1

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 23.04
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

We should try to ensure that all actions (especially those that some users may want to bind to shortcuts) extend JosmAction.

The affected dialogs and actions are as follows:

  • ChangesetDialog
    • SelectObjectsAction
    • ReadChangesetsAction
    • CloseOpenChangesetsAction
    • ShowChangesetInfoAction
    • LaunchChangesetManagerAction
  • CommandStackDialog
    • SelectAction
    • SelectAndZoomAction
    • Undo/Redo actions (since these are distinct from the global undo/redo action -- will undo/redo to the selected command)
  • FilterDialog
    • AddAction
    • EditAction
    • DeleteAction
    • MoveUpAction
    • MoveDownAction
    • SortAction
    • ReverseAction
  • MapPaintDialog
    • OnOffAction
    • MoveUpDownAction
  • NotesDialog
    • AddCommentAction
    • CloseAction
    • NewAction
    • ReopenAction
    • SortAction
    • OpenInBrowserAction
  • RelationListDialog
    • NewAction
  • UserListDialog
    • SelectUserPrimitivesAction
    • ShowUserInfoAction -- this calls a different super constructor actually

I don't see most of these getting shortcuts, especially official shortcuts, but some people on various chat channels have mentioned that they would like to have a shortcut for creating a new relation.

The current patch primarily focuses on actions for toggle dialogs.

Change History (2)

by taylor.smock, 3 years ago

Attachment: 22798.patch added

comment:1 by taylor.smock, 3 years ago

Description: modified (diff)
Milestone: 23.04
Summary: Convert actions which extend `AbstractAction` to ones which extend `JosmAction`[PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction`
Note: See TracTickets for help on using tickets.