Modify

#22798 closed defect (fixed)

[PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction`

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 23.04
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

We should try to ensure that all actions (especially those that some users may want to bind to shortcuts) extend JosmAction.

The affected dialogs and actions are as follows:

  • ChangesetDialog
    • SelectObjectsAction
    • ReadChangesetsAction
    • CloseOpenChangesetsAction
    • ShowChangesetInfoAction
    • LaunchChangesetManagerAction
  • CommandStackDialog
    • SelectAction
    • SelectAndZoomAction
    • Undo/Redo actions (since these are distinct from the global undo/redo action -- will undo/redo to the selected command)
  • FilterDialog
    • AddAction
    • EditAction
    • DeleteAction
    • MoveUpAction
    • MoveDownAction
    • SortAction
    • ReverseAction
  • MapPaintDialog
    • OnOffAction
    • MoveUpDownAction
  • NotesDialog
    • AddCommentAction
    • CloseAction
    • NewAction
    • ReopenAction
    • SortAction
    • OpenInBrowserAction
  • RelationListDialog
    • NewAction
  • UserListDialog
    • SelectUserPrimitivesAction
    • ShowUserInfoAction -- this calls a different super constructor actually

I don't see most of these getting shortcuts, especially official shortcuts, but some people on various chat channels have mentioned that they would like to have a shortcut for creating a new relation.

The current patch primarily focuses on actions for toggle dialogs.

Attachments (1)

22798.patch (37.3 KB ) - added by taylor.smock 14 months ago.

Download all attachments as: .zip

Change History (4)

by taylor.smock, 14 months ago

Attachment: 22798.patch added

comment:1 by taylor.smock, 14 months ago

Description: modified (diff)
Milestone: 23.04
Summary: Convert actions which extend `AbstractAction` to ones which extend `JosmAction`[PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction`

comment:2 by skyper, 14 months ago

See also #22801.

comment:3 by taylor.smock, 12 months ago

Resolution: fixed
Status: newclosed

In 18715/josm:

Fix #22798: Convert dialog actions which extend AbstractAction to ones which extend JosmAction

This will allow users to bind shortcuts to actions they make frequently, such as
creating new relations.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.